Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aerc: 0.18.2 -> 0.19.0 #373875

Merged
merged 1 commit into from
Jan 18, 2025
Merged

aerc: 0.18.2 -> 0.19.0 #373875

merged 1 commit into from
Jan 18, 2025

Conversation

jtbx
Copy link
Member

@jtbx jtbx commented Jan 14, 2025

https://git.sr.ht/~rjarry/aerc/refs/0.19.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@christoph-heiss christoph-heiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also smoke-tested the binary itself a bit.


x86_64-linux

✅ 1 package built:
  • aerc

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 16, 2025
@ilpianista ilpianista mentioned this pull request Jan 16, 2025
13 tasks
@ilpianista
Copy link
Contributor

@jtbx could you please add substituteAllInPlace doc/aerc-templates.7.scd in the postPatch as well?

@jtbx
Copy link
Member Author

jtbx commented Jan 16, 2025 via email

@sikmir
Copy link
Member

sikmir commented Jan 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373875


x86_64-darwin

✅ 1 package built:
  • aerc

@sikmir sikmir merged commit f70b5b8 into NixOS:master Jan 18, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants