-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
naja: 0-unstable-2024-08-27 -> 0-unstable-2025-01-13, fix cross #373848
Conversation
451f219
to
acbfb87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be building fine, but the executable doesn't work. I think we need to wrap it with the library as well:
./result/bin/naja_edit: error while loading shared libraries: libnaja_bne.so: cannot open shared object file: No such file or directory
acbfb87
to
cc69560
Compare
Fixed. Though I don't really understand why "libnaja_bne.so" wasn't put in the lib output automatically. |
|
With
Yeah, I'm quite curious as well. |
Oh right. I fixed capnproto cross some time ago but didn't get around to making a PR. |
cc69560
to
ac7cebf
Compare
Fixed now, without modifying capnproto. |
Yup, it cross-compiles fine now for aarch64.
Should we perhaps add a note to remove those two flags after the |
Also fix cross-compiling.
ac7cebf
to
e0d72ba
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot!
Simple update with some fixes for cross-compiling.
Things done