Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/neovim: better document the wrappers #373805

Merged
merged 7 commits into from
Jan 17, 2025

Conversation

teto
Copy link
Member

@teto teto commented Jan 14, 2025

there is new wrapper interface wrapNeovimUnstable in development intended to be easier to use than the old wrapNeovim. It provides new fancy features that we would like to leverage/advertise
The interface is not definitive yet so we provide a translation layer to avoid breaking user configurations such that wrapNeovim still works. This explains why we document both at the moment with the goal to remove the old one once we ciment the interface.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@PerchunPak
Copy link
Member

CC @BirdeeHub this is something you might be interested in

@BirdeeHub
Copy link
Contributor

BirdeeHub commented Jan 15, 2025

I kinda figured the wrapNeovimUnstable docs were kickstart-nix.nvim? I suppose that doesnt quite count as docs. I ate all the code from wrapNeovimUnstable for nixCats and changed it to fit nixCats so I know it well, due to editing almost every function. I labelled where its all from as well. But as you know, I am not good at docs XD

The above is kinda me joking but, yeah Im in favor of people knowing about these. Ups to teto for doing it.

But regardless, maybe inspiration can be pulled from there for documenting it.

@teto teto force-pushed the teto/neovim-document-new-wrapper branch from 88a4ca3 to 33178f9 Compare January 17, 2025 00:03
@teto teto marked this pull request as ready for review January 17, 2025 00:03
teto added 2 commits January 17, 2025 01:07
there is new wrapper interface `wrapNeovimUnstable` in development intended to be
easier to use than the old `wrapNeovim`. It provides new fancy features that we would like to
leverage/advertise
The interface is not definitive yet so we provide a translation layer
to avoid breaking user configurations such that `wrapNeovim` still works.
This explains why we document both at the moment with the goal to remove
the old one once we ciment the interface.
@teto teto force-pushed the teto/neovim-document-new-wrapper branch from 33178f9 to 9cb25d3 Compare January 17, 2025 00:08
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the additional detail! Just finally read through it more and did some grammar corrections and consistency tweaks.

doc/languages-frameworks/neovim.section.md Outdated Show resolved Hide resolved
doc/languages-frameworks/neovim.section.md Outdated Show resolved Hide resolved
doc/languages-frameworks/neovim.section.md Outdated Show resolved Hide resolved
doc/languages-frameworks/neovim.section.md Outdated Show resolved Hide resolved
doc/languages-frameworks/neovim.section.md Outdated Show resolved Hide resolved
doc/languages-frameworks/neovim.section.md Outdated Show resolved Hide resolved
doc/languages-frameworks/neovim.section.md Outdated Show resolved Hide resolved
@teto
Copy link
Member Author

teto commented Jan 17, 2025

@fricklerhandwerk i wanted to check the endresult by doing doc$ nix-build && firefox result/share/doc/nixpkgs/manual.html but clicking on the section led to 404.
Looking at the doc's doc (sic), I learned about the devmode command. Clicking http://127.0.0.1:8080/share/doc/nixpkgs/index.html#chap-language-support ends up with Cannot GET /share/doc/nixpkgs/index.html. Did I do something wrong ?

@khaneliman thanks for review. I've merged I think almost all of your comments. I think it's ready to go (we can squash from the UI).

@khaneliman khaneliman merged commit 9c73444 into NixOS:master Jan 17, 2025
26 of 28 checks passed
@teto teto deleted the teto/neovim-document-new-wrapper branch January 17, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants