-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/neovim: better document the wrappers #373805
doc/neovim: better document the wrappers #373805
Conversation
CC @BirdeeHub this is something you might be interested in |
I kinda figured the wrapNeovimUnstable docs were kickstart-nix.nvim? I suppose that doesnt quite count as docs. I ate all the code from wrapNeovimUnstable for nixCats and changed it to fit nixCats so I know it well, due to editing almost every function. I labelled where its all from as well. But as you know, I am not good at docs XD The above is kinda me joking but, yeah Im in favor of people knowing about these. Ups to teto for doing it. But regardless, maybe inspiration can be pulled from there for documenting it. |
88a4ca3
to
33178f9
Compare
there is new wrapper interface `wrapNeovimUnstable` in development intended to be easier to use than the old `wrapNeovim`. It provides new fancy features that we would like to leverage/advertise The interface is not definitive yet so we provide a translation layer to avoid breaking user configurations such that `wrapNeovim` still works. This explains why we document both at the moment with the goal to remove the old one once we ciment the interface.
33178f9
to
9cb25d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the additional detail! Just finally read through it more and did some grammar corrections and consistency tweaks.
Co-authored-by: Austin Horstman <[email protected]>
Co-authored-by: Austin Horstman <[email protected]>
Co-authored-by: Austin Horstman <[email protected]>
Co-authored-by: Austin Horstman <[email protected]>
@fricklerhandwerk i wanted to check the endresult by doing @khaneliman thanks for review. I've merged I think almost all of your comments. I think it's ready to go (we can squash from the UI). |
there is new wrapper interface
wrapNeovimUnstable
in development intended to be easier to use than the oldwrapNeovim
. It provides new fancy features that we would like to leverage/advertiseThe interface is not definitive yet so we provide a translation layer to avoid breaking user configurations such that
wrapNeovim
still works. This explains why we document both at the moment with the goal to remove the old one once we ciment the interface.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.