Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.web3: 6.5.0 -> 7.2.0 #373563

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

python312Packages.web3: 6.5.0 -> 7.2.0 #373563

wants to merge 14 commits into from
+548 −129

Conversation

hellwolf
Copy link
Contributor

@hellwolf hellwolf commented Jan 13, 2025 •
edited
Loading

Previously at: #342749

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@hellwolf hellwolf mentioned this pull request Jan 13, 2025
Open
13 tasks
@hellwolf hellwolf mentioned this pull request Jan 13, 2025
Open
1 task
@hellwolf hellwolf changed the title Web3py 7 6 python312Packages.web3: 6.5.0 -> 7.2.0 Jan 13, 2025
@hellwolf
Copy link
Contributor Author

@ofborg build python313Packages.web3

@nix-owners nix-owners bot requested a review from siraben January 13, 2025 23:24
@hellwolf hellwolf marked this pull request as ready for review January 14, 2025 10:03
@nix-owners nix-owners bot requested a review from natsukium January 14, 2025 10:04
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5083

@hellwolf
Copy link
Contributor Author

@ofborg build python313Packages.web3

GaetanLepage
GaetanLepage reviewed Jan 14, 2025
View reviewed changes
pkgs/development/python-modules/ckzg/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/ckzg/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/eth-abi/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/eth-hash/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/eth-hash/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/eth-keyfile/default.nix Outdated Show resolved Hide resolved
@hellwolf hellwolf force-pushed the web3py-7_6 branch 2 times, most recently from 6075b3d to 7e18f96 Compare January 14, 2025 10:30
@hellwolf
Copy link
Contributor Author

@GaetanLepage Thanks. I also went ahead and fixed other places regarding the rev vs tag attributes.

GaetanLepage
GaetanLepage reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be applied to all files.

pkgs/development/python-modules/trie/default.nix Outdated

pythonImportsCheck = [ "trie" ];

meta = with lib; {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with lib; {
meta = {

The with pattern is discouraged now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general, or just for the metadata?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this pattern is not ideal (costly and can lead to mistakes).
But here, I am talking about the with lib; specifically.
Keeping with lib.maintainers; for instance is fine IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed, anyhow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

--------- Impacted packages on 'x86_64-linux' ---------
12 packages added:
python312Packages.ckzg (init at 2.0.1) python312Packages.eth-bloom (init at 3.1.0) python312Packages.eth-tester (init at 0.12.0-beta.2) python312Packages.py-evm (init at 0.10.1-beta.2) python312Packages.pyunormalize (init at 16.0.0) python312Packages.trie (init at 3.0.1) python313Packages.ckzg (init at 2.0.1) python313Packages.eth-bloom (init at 3.1.0) python313Packages.eth-tester (init at 0.12.0-beta.2) python313Packages.py-evm (init at 0.10.1-beta.2) python313Packages.pyunormalize (init at 16.0.0) python313Packages.trie (init at 3.0.1)

3277 packages updated:

Probably not :D

pkgs/development/python-modules/trie/default.nix Show resolved Hide resolved
pkgs/development/python-modules/trie/default.nix Outdated Show resolved Hide resolved
PerchunPak
PerchunPak suggested changes Jan 14, 2025
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too many rebuilds, this should go to staging

@GaetanLepage correct me if I am wrong here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, good point. Why is that though ?
@hellwolf are you touching a deep package ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it all because the web3.py package itself.

Copy link
Contributor Author

@hellwolf hellwolf Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to do a nixpkgs-review pr` when things settle, and see how many changes follow.

Copy link
Contributor Author

@hellwolf hellwolf Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, my interest has been to maintain slither-analyzer echidna, which transitively dependon on web3.py.

if that's what you meant by "deep packages".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to do a nixpkgs-review pr` when things settle, and see how many changes follow.

Well, nixpkgs-review directly pulls the evaluation rebuilds from GitHub. So, if the GitHub action has labeled the PR with the 2501-5000 rebuilds tag, it will be the same in nixpkgs-review.

Why are so many packages depending on web3.py ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the GitHub action has labeled the PR with the 2501-5000 rebuilds tag, it will be the same in nixpkgs-review.

Ah, I didn't know!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are so many packages depending on web3.py ?

No idea!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But probably some other packages, not web3.py itself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting PR possible, just more work.

@siraben
Copy link
Member

siraben commented Jan 16, 2025 •
edited
Loading

I get 404 for one of the sources: https://codeload.github.com/mlodewijck/pyunormalize/tar.gz/refs/tags/4b45c576567fb0293acb93a308c97cbaba3caa5f

error: builder for '/nix/store/89mnhp5bgfv90gix6l9rpb6ppnx5zzs3-source.drv' failed with exit code 1;
       last 8 log lines:
       >
       > trying https://github.com/mlodewijck/pyunormalize/archive/refs/tags/4b45c576567fb0293acb93a308c97cbaba3caa5f.tar.gz
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (22) The requested URL returned error: 404
       > error: cannot download source from any mirror
       For full logs, run 'nix log /nix/store/89mnhp5bgfv90gix6l9rpb6ppnx5zzs3-source.drv'.
error: 1 dependencies of derivation '/nix/store/psiv0j6rz2ndcg8wjp2hwqpa8mckn6p6-python3.12-pyunormalize-16.0.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/4j1yx8f2wy02lwb03y00y1yqbrkfcdii-python3.12-web3-7.6.1.drv' failed to build

@hellwolf
Copy link
Contributor Author

I get 404 for one of the sources: https://codeload.github.com/mlodewijck/pyunormalize/tar.gz/refs/tags/4b45c576567fb0293acb93a308c97cbaba3caa5f

error: builder for '/nix/store/89mnhp5bgfv90gix6l9rpb6ppnx5zzs3-source.drv' failed with exit code 1;
       last 8 log lines:
       >
       > trying https://github.com/mlodewijck/pyunormalize/archive/refs/tags/4b45c576567fb0293acb93a308c97cbaba3caa5f.tar.gz
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (22) The requested URL returned error: 404
       > error: cannot download source from any mirror
       For full logs, run 'nix log /nix/store/89mnhp5bgfv90gix6l9rpb6ppnx5zzs3-source.drv'.
error: 1 dependencies of derivation '/nix/store/psiv0j6rz2ndcg8wjp2hwqpa8mckn6p6-python3.12-pyunormalize-16.0.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/4j1yx8f2wy02lwb03y00y1yqbrkfcdii-python3.12-web3-7.6.1.drv' failed to build

right. that should be a ref, not tag. I will fix

@hellwolf
Copy link
Contributor Author

I made one more round clean up according to the suggestion. @GaetanLepage

And please give it another try @siraben

@GaetanLepage
Copy link
Contributor

I made one more round clean up according to the suggestion. @GaetanLepage

Thanks. A few more are still not applied.
Also, don't forget about re-ordering the derivation inputs ;)

@hellwolf
Copy link
Contributor Author

hellwolf commented Jan 17, 2025 •
edited
Loading

Thanks. A few more are still not applied.

what are they?

Also, don't forget about re-ordering the derivation inputs ;)

Okay, I will create a new TODO list.

@hellwolf
Copy link
Contributor Author

@GaetanLepage I have tidied the code up. I also have fixed commit messages.

@hellwolf hellwolf force-pushed the web3py-7_6 branch 2 times, most recently from 2dd6bea to f686ac5 Compare January 18, 2025 15:33
GaetanLepage
GaetanLepage reviewed Jan 19, 2025
View reviewed changes
pkgs/development/python-modules/eth-typing/default.nix
Comment on lines +42 to 44
changelog = "https://github.com/ethereum/eth-typing/blob/v${version}/docs/release_notes.rst";
description = "Common type annotations for Ethereum Python packages";
homepage = "https://github.com/ethereum/eth-typing";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
changelog = "https://github.com/ethereum/eth-typing/blob/v${version}/docs/release_notes.rst";
description = "Common type annotations for Ethereum Python packages";
homepage = "https://github.com/ethereum/eth-typing";
description = "Common type annotations for Ethereum Python packages";
homepage = "https://github.com/ethereum/eth-typing";
changelog = "https://github.com/ethereum/eth-typing/blob/v${version}/docs/release_notes.rst";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage requested changes

@PerchunPak PerchunPak PerchunPak requested changes

@siraben siraben Awaiting requested review from siraben

@natsukium natsukium Awaiting requested review from natsukium

@mweinelt mweinelt Awaiting requested review from mweinelt

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hellwolf @nixos-discourse @siraben @GaetanLepage @mweinelt @PerchunPak @FlorianFranzen