[Backport release-24.11] nixpkgs-review: 2.12.0 -> 3.0.1 #373534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff: Mic92/nixpkgs-review@refs/tags/2.12.0...3.0.0 Changelog: https://github.com/Mic92/nixpkgs-review/releases/tag/3.0.0 (cherry picked from commit 170a250)
Diff: Mic92/nixpkgs-review@refs/tags/3.0.0...3.0.1 Changelog: https://github.com/Mic92/nixpkgs-review/releases/tag/3.0.1 (cherry picked from commit dc208d2)
github-actions
bot
added
6.topic: python
8.has: documentation
ofborg
bot
added
the
2.status: merge conflict
github-actions
bot
removed
6.topic: python
8.has: documentation
ofborg
bot
removed
the
2.status: merge conflict
|
Today I learnt: pressing enter while editing the title of a Github PR creates it, which happened before I changed the base branch. :) Good thing mass pings are a thing of the past. |
getchoo
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Thanks for this, it's been a little annoying on my server 😆
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 373534
aarch64-linux
✅ 4 packages built:
- nix-update
- nix-update.dist
- nixpkgs-review
- nixpkgs-review.dist
x86_64-darwin
✅ 4 packages built:
- nix-update
- nix-update.dist
- nixpkgs-review
- nixpkgs-review.dist
aarch64-darwin
✅ 4 packages built:
- nix-update
- nix-update.dist
- nixpkgs-review
- nixpkgs-review.dist
getchoo
added
the
12.approvals: 1
13 tasks
FliegendeWurst
approved these changes
Jan 13, 2025
FliegendeWurst
added
12.approvals: 2
|
Great thanks for backporting. I just hit the issue with ofborg cache . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #366587 and #370816 (combined in one manual cherry-pick PR so we don't have two separate backport PRs).
Motivation: nixpkgs-review 2.x relies on the ofborg cache and at least for me does not fallback to local evaluation anymore when it does not find the cached ofborg evaluation, which is the case for all new nixpkgs PRs.
Discussion on Matrix.
This leaves 2.x in a somewhat broken state and can cause confusion for reviewers using stable. nixpkgs-review 3.x is required to fetch the evaluation cache of the new Github Actions evaluation.
@emilazy fittingly described it in a joking way: "nixpkgs-review is a live service game".
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.