Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asterisk: 20.11.0 -> 20.11.1 #373356

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for asterisk is: Software implementation of a telephone private branch exchange (PBX)

meta.homepage for asterisk is: https://www.asterisk.org/

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 20.11.1 with grep in /nix/store/v2y01knvc5w1bgchkcalmwql71zrzazl-asterisk-20.11.1
  • found 20.11.1 in filename of file in /nix/store/v2y01knvc5w1bgchkcalmwql71zrzazl-asterisk-20.11.1

Rebuild report (if merged into master) (click to expand)
8 total rebuild path(s)

8 package rebuild(s)

First fifty rebuilds by attrpath

asterisk
asterisk-ldap
asterisk-lts
asterisk-module-sccp
asterisk-stable
asterisk_18
asterisk_20
Instructions to test this update (click to expand)

Either download from the cache:

nix-store -r /nix/store/v2y01knvc5w1bgchkcalmwql71zrzazl-asterisk-20.11.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A asterisk https://github.com/r-ryantm/nixpkgs/archive/c9eb178b9d565336ce7f98272c2d33dc511a68df.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/c9eb178b9d565336ce7f98272c2d33dc511a68df#asterisk

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/v2y01knvc5w1bgchkcalmwql71zrzazl-asterisk-20.11.1
ls -la /nix/store/v2y01knvc5w1bgchkcalmwql71zrzazl-asterisk-20.11.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 4 packages built:
  • asterisk (asterisk-stable ,asterisk_20)
  • asterisk-ldap
  • asterisk_18 (asterisk-lts)
  • asterisk-module-sccp

Maintainer pings

cc @auntieNeo @DerTim1 @yorickvP for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 13, 2025
Copy link
Contributor

@Yarny0 Yarny0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review per https://github.com/NixOS/nixpkgs/tree/130595eba61081acde9001f43de3248d8888ac4a/pkgs#package-updates

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package builds on x86-64
  • executables tested on x86-64
  • all depending packages build
  • patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed
  • patches that are remotely available are fetched rather than vendored

More:

  • used asterisk with iaxmodem client to send/receive some faxes
  • used dialplan functions Busy, Wait, Answer, Playback, Goto, Dial
Comments

Only tested versions 18 and 20, after cherry-picking the commit onto a recent nixos-unstable. Everything works as expected, this can be merged!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2192

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 14, 2025
@misuzu misuzu added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jan 14, 2025
@misuzu
Copy link
Contributor

misuzu commented Jan 14, 2025

GHSA-33x6-fj46-6rfh

@misuzu misuzu merged commit 0529925 into NixOS:master Jan 14, 2025
26 of 29 checks passed
@LeSuisse
Copy link
Contributor

LeSuisse commented Jan 14, 2025

This need a port to stable

@LeSuisse LeSuisse added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 14, 2025
@LeSuisse
Copy link
Contributor

Backport in #373859

@r-ryantm r-ryantm deleted the auto-update/asterisk branch January 15, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants