astroterm: init at 1.0.4, maintainers: add da-luce

[da-luce]

Adds a new package for da-luce/astroterm. This is a celestial viewer for the terminal, displaying stars, planets, and more. For example:

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[SigmaSquadron]

Welcome to Nixpkgs! Thanks for packaging your software.

[SigmaSquadron]

nixpkgs-review is being weird due to the OfBorg failure, but that can be ignored.

Built on x86_64-linux:

$ ./astroterm --version
astroterm 1.0.3

[da-luce]

nixpkgs-review is being weird due to the OfBorg failure, but that can be ignored.

@SigmaSquadron, could you clarify why it's safe to ignore this failure? My initial suspicion is that xxd might not have generated a valid header due to some unexpected behavior on the Linux build. Since I'm not very familiar with OfBorg or Nix, could you provide some guidance on how to begin debugging this?

[SigmaSquadron]

The majority of our CI system is currently broken, and OfBorg shouldn't even be building things. This error can be ignored because the build works on an actual Linux system, and OfBorg results cannot be trusted until its builders are restored to a working state.

[FliegendeWurst]

I get a build failure when building on master: https://paste.fliegendewurst.eu/LyBtYd.log

FAILED: libastroterm_lib.a.p/src_core.c.o 
gcc -Ilibastroterm_lib.a.p -I. -I.. -I../include -Idata -I../data -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Wpedantic -DHAVE_ARGTABLE3 -fPIC -MD -MQ libastroterm_lib.a.p/src_core.c.o -MF libastroterm_lib.a.p/src_core.c.o.d -o libastroterm_lib.a.p/src_core.c.o -c ../src/core.c
../src/core.c: In function 'string_to_time':
../src/core.c:493:27: error: implicit declaration of function 'strptime'; did you mean 'strftime'? [-Wimplicit-function-declaration]
  493 |     const char *pointer = strptime(string, "%Y-%m-%dT%H:%M:%S", time);
      |                           ^~~~~~~~
      |                           strftime
../src/core.c:493:27: error: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]

[FliegendeWurst]

Build log says Checking for function "strptime" : YES and still fails with the same error.

[da-luce]

@FliegendeWurst I suspect the local implementation not be including the header correctly. Will update once fixed.

I would test locally but I'm unable to reproduce on WSL. Windows uses the local implementation but MSVC doesn't complain about implicit declarations.

Update: issue may have been that certain definitions were missing as described here

[FliegendeWurst]

Do you set -no-pie somewhere in your build? We are planning to enable PIE by default soon.

[da-luce]

Do you set -no-pie somewhere in your build? We are planning to enable PIE by default soon.

Yeah. The argtable3 library on Homebrew for Linux is non-PIC, so the only fix I found for that was to make my own code non-PIC.

[FliegendeWurst]

Our argtable is PIC. So it would be good make -no-pie optional :)

[da-luce]

Good point. Should have been passing as a CLI arg and not baked into the build file in the first place. Removed -no-pie flag.

[sikmir]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373316

---

x86_64-darwin

✅ 1 package built:

• astroterm

[sikmir]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373316

---

x86_64-linux

✅ 1 package built:

• astroterm