-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lvm2: put the profile scripts into etc/profile.d
#373288
base: staging
Are you sure you want to change the base?
Conversation
The PR's base branch is set to master, but 1149 commits from the staging branch are included. Make sure you know the right base branch for your changes, then:
|
You still seem to have 11 commits from another branch in this PR. I suggest you rebase interactively and drop them - those are probably commits that were on master already, but didn't make their way to staging at the time, yet. |
"--with-default-run-dir=/run/lvm" | ||
"--with-systemdsystemunitdir=${placeholder "out"}/lib/systemd/system" | ||
"--with-systemd-run=/run/current-system/systemd/bin/systemd-run" | ||
"--with-default-profile-subdir=profile.d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this line is the added one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's only a single line change, then I think you still need another rebase, so that the diff is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or did you run nixfmt on this file?
Then it would be good to split this into a separate commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latter, because otherwise CI complained, while the real change is hopefully pretty trivial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should really split the nixfmt change and the actual change into separate commits. That would make it much easier to review. Even with whitespace changes invisible, it's a few changes...
It looks like |
Motivation: #369732
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.