Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: remove explicit nvimRequireCheck pt2 #373283

Merged
merged 7 commits into from
Jan 12, 2025

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Jan 12, 2025

Things done

Follow up to #367801
Also discovered yetone/avante.nvim#1074 while doing this.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested review from redxtech and Balssh January 12, 2025 22:00
@khaneliman khaneliman marked this pull request as ready for review January 12, 2025 22:10
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@khaneliman khaneliman changed the title vimPackages: remove explicit nvimRequireCheck pt2 vimPlugins: remove explicit nvimRequireCheck pt2 Jan 12, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373283


x86_64-linux

✅ 9 packages built:
  • vimPlugins.avante-nvim
  • vimPlugins.blink-cmp
  • vimPlugins.blink-emoji-nvim
  • vimPlugins.codesnap-nvim
  • vimPlugins.cord-nvim
  • vimPlugins.nvim-spectre
  • vimPlugins.sg-nvim
  • vimPlugins.sniprun
  • vimPluginsUpdater

aarch64-linux

✅ 9 packages built:
  • vimPlugins.avante-nvim
  • vimPlugins.blink-cmp
  • vimPlugins.blink-emoji-nvim
  • vimPlugins.codesnap-nvim
  • vimPlugins.cord-nvim
  • vimPlugins.nvim-spectre
  • vimPlugins.sg-nvim
  • vimPlugins.sniprun
  • vimPluginsUpdater

x86_64-darwin

✅ 9 packages built:
  • vimPlugins.avante-nvim
  • vimPlugins.blink-cmp
  • vimPlugins.blink-emoji-nvim
  • vimPlugins.codesnap-nvim
  • vimPlugins.cord-nvim
  • vimPlugins.nvim-spectre
  • vimPlugins.sg-nvim
  • vimPlugins.sniprun
  • vimPluginsUpdater

aarch64-darwin

✅ 9 packages built:
  • vimPlugins.avante-nvim
  • vimPlugins.blink-cmp
  • vimPlugins.blink-emoji-nvim
  • vimPlugins.codesnap-nvim
  • vimPlugins.cord-nvim
  • vimPlugins.nvim-spectre
  • vimPlugins.sg-nvim
  • vimPlugins.sniprun
  • vimPluginsUpdater

@GaetanLepage GaetanLepage merged commit 5d36278 into NixOS:master Jan 12, 2025
33 checks passed
@khaneliman khaneliman deleted the vim-require branch January 12, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants