Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ejabberd: fix mod_matrix_gw #373257

Merged
merged 2 commits into from
Jan 15, 2025
Merged

ejabberd: fix mod_matrix_gw #373257

merged 2 commits into from
Jan 15, 2025

Conversation

chuangzhu
Copy link
Contributor

@chuangzhu chuangzhu commented Jan 12, 2025 •
edited
Loading

Fix #371148 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jan 12, 2025
@chuangzhu chuangzhu mentioned this pull request Jan 12, 2025
Merged
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 12, 2025
toastal
toastal suggested changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@toastal toastal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curl "https://@HOST@:8448/_matrix/key/v2/server" should fail if this bug is real.

https://federationtester.matrix.org querying this URL to verify federation is properly set up & is what caused the Ejabberd server to report a runtime error, not startup.

nixos/tests/xmpp/ejabberd.nix Outdated Show resolved Hide resolved
@github-actions github-actions bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 13, 2025
@nix-owners nix-owners bot requested review from svanderburg and abbradar January 13, 2025 00:01
@toastal
Copy link
Contributor

toastal commented Jan 13, 2025

Nice

@chuangzhu chuangzhu changed the title nixosTests.ejabberd: add matrix test ejabberd: fix mod_matrix_gw Jan 14, 2025
@chuangzhu chuangzhu marked this pull request as ready for review January 14, 2025 21:13
@chuangzhu chuangzhu requested review from adamcstephens and a team January 14, 2025 21:14
@adamcstephens adamcstephens merged commit d7034af into NixOS:master Jan 15, 2025
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toastal toastal toastal requested changes

@svanderburg svanderburg Awaiting requested review from svanderburg

@abbradar abbradar Awaiting requested review from abbradar

@adamcstephens adamcstephens Awaiting requested review from adamcstephens

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chuangzhu @toastal @adamcstephens