Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lockbook-desktop: 0.9.15 -> 0.9.16 #373059

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

Parth
Copy link
Member

@Parth Parth commented Jan 11, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Parth Parth added the backport release-24.11 Backport PR automatically label Jan 11, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 11, 2025
@Parth
Copy link
Member Author

Parth commented Jan 14, 2025

👋 @donovanglover @Aleksanaa @wolfgangwalther could you take a look at this when you have a moment?

@wolfgangwalther
Copy link
Contributor

You checked the boxes for "have built on xxx-darwin", too. Does that mean it runs on MacOS as well?

Currently you have this platforms = lib.platforms.linux; and we have no darwin rebuilds (as you can see from CI / labels). So if we could enable darwin, that would be great.

@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373059


x86_64-linux

✅ 1 package built:
  • lockbook-desktop

aarch64-linux

✅ 1 package built:
  • lockbook-desktop

@Parth
Copy link
Member Author

Parth commented Jan 14, 2025

Hey @wolfgangwalther thanks for having a look, I did not mean to check that box, I have unchecked it!

@wolfgangwalther wolfgangwalther merged commit df3dcce into NixOS:master Jan 14, 2025
73 of 76 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 14, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants