Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lockbook: 0.9.15 -> 0.9.16 #373058

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

Parth
Copy link
Member

@Parth Parth commented Jan 11, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Parth
Copy link
Member Author

Parth commented Jan 14, 2025

👋 @donovanglover @Aleksanaa @wolfgangwalther could you (also) take a look at this when you have a moment?

@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373058


x86_64-linux

✅ 1 package built:
  • lockbook

aarch64-linux

✅ 1 package built:
  • lockbook

x86_64-darwin

✅ 1 package built:
  • lockbook

aarch64-darwin

✅ 1 package built:
  • lockbook

@wolfgangwalther wolfgangwalther merged commit aa21024 into NixOS:master Jan 14, 2025
25 of 28 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 14, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-373058-to-release-24.11 origin/release-24.11
cd .worktree/backport-373058-to-release-24.11
git switch --create backport-373058-to-release-24.11
git cherry-pick -x 01aa1e3212b6995b163f1be702974a419c7ed7dc

@Parth Parth added backport release-24.11 Backport PR automatically and removed backport release-24.11 Backport PR automatically labels Jan 14, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 14, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-373058-to-release-24.11 origin/release-24.11
cd .worktree/backport-373058-to-release-24.11
git switch --create backport-373058-to-release-24.11
git cherry-pick -x 01aa1e3212b6995b163f1be702974a419c7ed7dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants