Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging 24.11] vim: 9.1.0787 -> 9.1.1006 #372981

Draft
wants to merge 3 commits into
base: staging-24.11
Choose a base branch
from
Draft

[staging 24.11] vim: 9.1.0787 -> 9.1.1006 #372981

wants to merge 3 commits into from

Conversation

philiptaron
Copy link
Contributor

@philiptaron philiptaron commented Jan 11, 2025 •
edited
Loading

Resolves GHSA-5rgf-26wj-48v8.

vim/vim@v9.1.0787...v9.1.1006

I've scanned through this set of commit messages and don't see anything that is breaking-change worthy, and the changes to https://github.com/vim/vim/blame/master/runtime/doc/version9.txt back that up. This is normal for Vim.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@philiptaron philiptaron added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jan 11, 2025
@philiptaron philiptaron changed the title vim: 9.1.0787 -> 9.1.1006 [staging 24.11] vim: 9.1.0787 -> 9.1.1006 Jan 11, 2025
@philiptaron
Copy link
Contributor Author

Staging PR: #372980

@philiptaron philiptaron requested a review from LeSuisse January 11, 2025 17:14
@mweinelt
Copy link
Member

mweinelt commented Jan 11, 2025 •
edited
Loading

The commits are not picked with the -x flag, meaning they don't refer to the commit they were picked from.

@philiptaron
Copy link
Contributor Author

The commits are not picked with the -x flag, meaning they don't refer to the commit they were picked from.

Ah, so in order to have this be a PR "in order", the staging PR must be merged first?

@philiptaron philiptaron marked this pull request as draft January 16, 2025 18:32
@philiptaron
Copy link
Contributor Author

Converting to draft until staging PR #372980 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

@dasJ dasJ Awaiting requested review from dasJ

@equirosa equirosa Awaiting requested review from equirosa

@LeSuisse LeSuisse Awaiting requested review from LeSuisse

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: vim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philiptaron @mweinelt @r-ryantm