Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sddm-astronaut: 1.0 -> 1.0-unstable-2025-01-05 #372568

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

uxodb
Copy link
Member

@uxodb uxodb commented Jan 10, 2025

Added myself as a maintainer (to update/contribute some pkgs soon)

edit: updated package, and added option to select one of the embedded themes, added myself as pkg maintainer

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 10, 2025
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 10, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 10, 2025
@uxodb uxodb changed the title maintainers: add uxodb sddm-astronaut: update package Jan 12, 2025
@github-actions github-actions bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 12, 2025
@nix-owners nix-owners bot requested a review from DaniD3v January 12, 2025 21:25
@uxodb uxodb changed the title sddm-astronaut: update package sddm-astronaut: 1.0 -> 1.0-unstable-2025-01-05 Jan 13, 2025
@FliegendeWurst
Copy link
Member

Last four commits can be squashed. Make sure the commit message follows the guidelines.

@uxodb
Copy link
Member Author

uxodb commented Jan 14, 2025

Thanks @FliegendeWurst.
Squashed all commits by accident, and github is having issues, so I suddenly couldnt push. Will try pushing later.

edit: done

@DaniD3v
Copy link
Contributor

DaniD3v commented Jan 14, 2025

Thanks a lot for the update.
I totally missed the new themes.

Do you think we could use pkgs.makeDesktopItem instead? I dont really like the sed workaround.

We can use builtins.fromTOML to convert the existing desktop file into a nix expression and then override the ConfigFile field, leaving everything else as-is.

If that does not end up working out please add a comment explaining what the sed command does.

@uxodb uxodb requested a review from DaniD3v January 14, 2025 10:25
@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 14, 2025
@uxodb uxodb requested a review from FliegendeWurst January 15, 2025 01:56
@FliegendeWurst FliegendeWurst merged commit 6396330 into NixOS:master Jan 15, 2025
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants