Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargonode: 0.1.2 -> 0.1.3 #372469

Merged
merged 1 commit into from
Jan 18, 2025
Merged

cargonode: 0.1.2 -> 0.1.3 #372469

merged 1 commit into from
Jan 18, 2025

Conversation

xosnrdev
Copy link
Contributor

@xosnrdev xosnrdev commented Jan 9, 2025

Changelog: https://github.com/xosnrdev/cargonode/blob/master/CHANGELOG.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lucasew
Copy link
Contributor

lucasew commented Jan 9, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372469


x86_64-linux

✅ 1 package built:
  • cargonode

@0Supa 0Supa removed their request for review January 15, 2025 00:16
Copy link
Contributor

@0nyr 0nyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward upgrade of the package version and hash.

Tested locally on my machine with nix-build -E 'with import <nixpkgs> {}; callPackage ./package.nix {}' and works fine:

 ❮onyr ★ nixos❯ ❮Downloads❯❯ nix-build -E 'with import <nixpkgs> {}; callPackage ./package.nix {}'
these 3 derivations will be built:
  /nix/store/27q3086pcsgjf5hhpjlvn77fhzc1hbrs-source.drv
  /nix/store/9wg0lzr1swisgmqghssigp7rah6hmpbz-cargonode-0.1.3-vendor.tar.gz.drv
  /nix/store/w3mw7mwla49hvqk2lavkngg0kk5pghwn-cargonode-0.1.3.drv
these 11 paths will be fetched (171.98 MiB download, 805.28 MiB unpacked):
  /nix/store/r0qnqmfq11rpf6n6zflld014xjp5808l-auditable-cargo-1.82.0
  /nix/store/9113334r56fmi13i8j6k8r2x92ml3c6b-cargo-1.82.0
  /nix/store/ydhbsmaazzw9q9ny1i5yjk850mmmfanl-cargo-auditable-0.6.2
  /nix/store/j4qrwpqim26jhm243im22wzgxb7w0gxk-cargo-build-hook.sh
  /nix/store/2ai38pkyd83mcvs0lr9nwh38xpnihxga-cargo-check-hook.sh
  /nix/store/n8xilr39f5b6q6givmvq6qsrmyfhlzws-cargo-install-hook.sh
  /nix/store/8950g8dgzmy2gslcg1dcn5dkl5b64018-cargo-setup-hook.sh
  /nix/store/fh7vjdscr0jc0qww7wvfw739vzglynpy-cargo-vendor-normalise
  /nix/store/d1r4w7mhq6v7vvr0r8cf3wi4jhmyrdik-python3.12-toml-0.10.2
  /nix/store/wi84ms5hw85w3frljv2spmdl8768dw97-rustc-1.82.0
  /nix/store/rkj4nka0cyjnap3l6x2xbgv48fwm2yq1-rustc-wrapper-1.82.0
copying path '/nix/store/n8xilr39f5b6q6givmvq6qsrmyfhlzws-cargo-install-hook.sh' from 'https://cache.nixos.org'...
copying path '/nix/store/ydhbsmaazzw9q9ny1i5yjk850mmmfanl-cargo-auditable-0.6.2' from 'https://cache.nixos.org'...
copying path '/nix/store/8950g8dgzmy2gslcg1dcn5dkl5b64018-cargo-setup-hook.sh' from 'https://cache.nixos.org'...
copying path '/nix/store/wi84ms5hw85w3frljv2spmdl8768dw97-rustc-1.82.0' from 'https://cache.nixos.org'...
building '/nix/store/27q3086pcsgjf5hhpjlvn77fhzc1hbrs-source.drv'...
copying path '/nix/store/d1r4w7mhq6v7vvr0r8cf3wi4jhmyrdik-python3.12-toml-0.10.2' from 'https://cache.nixos.org'...
copying path '/nix/store/fh7vjdscr0jc0qww7wvfw739vzglynpy-cargo-vendor-normalise' from 'https://cache.nixos.org'...

trying https://github.com/xosnrdev/cargonode/archive/refs/tags/0.1.3.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   98k    0   98k    0     0  97901      0 --:--:--  0:00:01 --:--:-- 97901
unpacking source archive /build/0.1.3.tar.gz
copying path '/nix/store/rkj4nka0cyjnap3l6x2xbgv48fwm2yq1-rustc-wrapper-1.82.0' from 'https://cache.nixos.org'...
copying path '/nix/store/9113334r56fmi13i8j6k8r2x92ml3c6b-cargo-1.82.0' from 'https://cache.nixos.org'...
copying path '/nix/store/2ai38pkyd83mcvs0lr9nwh38xpnihxga-cargo-check-hook.sh' from 'https://cache.nixos.org'...
copying path '/nix/store/j4qrwpqim26jhm243im22wzgxb7w0gxk-cargo-build-hook.sh' from 'https://cache.nixos.org'...
copying path '/nix/store/r0qnqmfq11rpf6n6zflld014xjp5808l-auditable-cargo-1.82.0' from 'https://cache.nixos.org'...
building '/nix/store/9wg0lzr1swisgmqghssigp7rah6hmpbz-cargonode-0.1.3-vendor.tar.gz.drv'...
Running phase: unpackPhase
unpacking source archive /nix/store/nxq00qx4qckfyk7jsn0yf5l2vp6hg9hj-source
source root is source
Running phase: patchPhase
Running phase: updateAutotoolsGnuConfigScriptsPhase
Running phase: buildPhase
    Updating crates.io index
 Downloading crates ...
  Downloaded thiserror v1.0.69
  Downloaded tinystr v0.7.6
  [...]
  Downloaded linux-raw-sys v0.4.14
  Downloaded ring v0.17.8
   Vendoring adler2 v2.0.0 (/build/source/cargo-home.vXL/registry/src/index.crates.io-6f17d22bba15001f/adler2-2.0.0) to cargonode-0.1.3-vendor.tar.gz/adler2
   Vendoring aes v0.8.4 (/build/source/cargo-home.vXL/registry/src/index.crates.io-6f17d22bba15001f/aes-0.8.4) to cargonode-0.1.3-vendor.tar.gz/aes
   Vendoring anstream v0.6.18 (/build/source/cargo-home.vXL/registry/src/index.crates.io-6f17d22bba15001f/anstream-0.6.18) to cargonode-0.1.3-vendor.tar.gz/anstream
   Vendoring anstyle v1.0.10 (/build/source/cargo-home.vXL/registry/src/index.crates.io-6f17d22bba15001f/anstyle-1.0.10) to cargonode-0.1.3-vendor.tar.gz/anstyle
[...]
Running phase: installPhase
Running phase: fixupPhase
shrinking RPATHs of ELF executables and libraries in /nix/store/d2svwz5gc9y646syqjimfnfcazvqvq7r-cargonode-0.1.3-vendor.tar.gz
checking for references to /build/ in /nix/store/d2svwz5gc9y646syqjimfnfcazvqvq7r-cargonode-0.1.3-vendor.tar.gz...
patching script interpreter paths in /nix/store/d2svwz5gc9y646syqjimfnfcazvqvq7r-cargonode-0.1.3-vendor.tar.gz
building '/nix/store/w3mw7mwla49hvqk2lavkngg0kk5pghwn-cargonode-0.1.3.drv'...
Running phase: unpackPhase
unpacking source archive /nix/store/nxq00qx4qckfyk7jsn0yf5l2vp6hg9hj-source
source root is source
Executing cargoSetupPostUnpackHook
unpacking source archive /nix/store/d2svwz5gc9y646syqjimfnfcazvqvq7r-cargonode-0.1.3-vendor.tar.gz
Finished cargoSetupPostUnpackHook
Running phase: patchPhase
Executing cargoSetupPostPatchHook
Validating consistency between /build/source/Cargo.lock and /build/cargonode-0.1.3-vendor.tar.gz/Cargo.lock
Finished cargoSetupPostPatchHook
Running phase: updateAutotoolsGnuConfigScriptsPhase
Running phase: configurePhase
Running phase: buildPhase
Executing cargoBuildHook
cargoBuildHook flags: -j 20 --target x86_64-unknown-linux-gnu --offline --profile release
   Compiling proc-macro2 v1.0.92
   Compiling unicode-ident v1.0.14
   Compiling libc v0.2.167
   Compiling shlex v1.3.0
   [...]
   Compiling zstd v0.13.2
   Compiling zip-extract v0.2.1
    Finished `release` profile [optimized + debuginfo] target(s) in 27.00s
Executing cargoInstallPostBuildHook
Finished cargoInstallPostBuildHook
Finished cargoBuildHook
Running phase: checkPhase
Executing cargoCheckHook
cargoCheckHook flags: -j 20 --profile release --target x86_64-unknown-linux-gnu --offline -- --test-threads=20 --skip test_download_file --skip test_extract_zip --skip test_invalid_download_url --skip test_create_package --skip test_init_package
   Compiling cargonode v0.1.3 (/build/source)
    Finished `release` profile [optimized + debuginfo] target(s) in 1.16s
     Running unittests src/lib.rs (target/x86_64-unknown-linux-gnu/release/deps/cargonode-1be82a12dacf717c)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/main.rs (target/x86_64-unknown-linux-gnu/release/deps/cargonode-81db4a3f776ba120)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/integration_test.rs (target/x86_64-unknown-linux-gnu/release/deps/integration_test-2e151deeb057df24)

running 11 tests
test test_command_parsing ... ok
test test_default_command_configurations ... ok
test test_merge_with_empty_file_config ... ok
test test_merge_with_empty_or_whitespace_vectors ... ok
test test_merge_with_empty_whitespace_and_non_empty_vectors ... ok
test test_merge_with_full_file_config ... ok
test test_environment_variable_merging ... ok
test test_merge_with_no_file_config ... ok
test test_merge_with_partial_whitespace_vectors ... ok
test test_merge_with_partial_file_config ... ok
test test_pre_check_configurations ... ok

test result: ok. 11 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/package_test.rs (target/x86_64-unknown-linux-gnu/release/deps/package_test-49acd3f6a34a8cc6)

running 5 tests
test test_invalid_package_names ... ok
test test_error_display ... ok
test test_valid_package_names ... ok
test test_directory_placeholder_replacement ... ok
test test_replace_placeholders ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 5 filtered out; finished in 0.01s

   Doc-tests cargonode

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Finished cargoCheckHook
Running phase: installPhase
Executing cargoInstallHook
Finished cargoInstallHook
Running phase: fixupPhase
shrinking RPATHs of ELF executables and libraries in /nix/store/fywng6h777c51kd5g1hkadchac4qxxw5-cargonode-0.1.3
shrinking /nix/store/fywng6h777c51kd5g1hkadchac4qxxw5-cargonode-0.1.3/bin/cargonode
checking for references to /build/ in /nix/store/fywng6h777c51kd5g1hkadchac4qxxw5-cargonode-0.1.3...
patching script interpreter paths in /nix/store/fywng6h777c51kd5g1hkadchac4qxxw5-cargonode-0.1.3
stripping (with command strip and flags -S -p) in  /nix/store/fywng6h777c51kd5g1hkadchac4qxxw5-cargonode-0.1.3/bin
/nix/store/fywng6h777c51kd5g1hkadchac4qxxw5-cargonode-0.1.3

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 15, 2025
@pbsds pbsds merged commit 3010e3c into NixOS:master Jan 18, 2025
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants