elixir: use env shebang only on Darwin #372297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mix
program from theelixir
package has a long shebang:136 characters. Historical PR comments note that we include the
env
invocation even though we give an exact binary path because Darwin won't use another interpreted script as this program's interpreter.I'm working on improving compatibility with older Linux kernels, which have a limit of 127 characters in the shebang command. This PR removes the
env
command other than in Darwin, which will bring us well under 127 characters.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
) <- kind of, onlymix
Add a 👍 reaction to pull requests you find important.