keylight-cli: init at 1.0.0 #371935
keylight-cli: init at 1.0.0 #371935
Conversation
NixOSInfra
added
the
12. first-time contribution
versality
force-pushed
the
master
branch
3 times, most recently
from
48a1fa3 to
3e7b214
Compare
github-actions
bot
added
8.has: maintainer-list (update)
versality
force-pushed
the
master
branch
2 times, most recently
from
eb64d15 to
e9ecabb
Compare
|
| meta = with lib; { | ||
| description = "CLI tool to control Elgato Key Light devices"; | ||
| homepage = "https://github.com/versality/keylight-cli"; | ||
| license = licenses.gpl2; |
There was a problem hiding this comment.
licenses.gpl2 is deprecated, consider using licenses.gpl2Only. Or licenses.gpl2Plus if you meant that, but you'd need to state that in your upstream repo.
See:
Line 1374 in 2fdec2c
There was a problem hiding this comment.
Thank you. I have changed it to licenses.gpl2Only.
| src = fetchFromGitHub { | ||
| owner = "versality"; | ||
| repo = "keylight-cli"; | ||
| rev = "46ff8472f9544e16eea822bf274acf4a5cbedbe8"; |
There was a problem hiding this comment.
I just realised that the rev field in fetchFromGithub can be a git tag, like "v${version}", in this case.
There was a problem hiding this comment.
I just realised that the
revfield in fetchFromGithub can be a git tag, like"v${version}", in this case.
Thanks for the suggestion! The upstream repo doesn't use tags yet, but I'll consider adding them in the future. For now, the git hash should work fine for pinning the version.
There was a problem hiding this comment.
There's also the passthru.updateScript = nix-update-script { }, see the wiki article on it. I can't vouch for it as I haven't yet used it, only requested to use it on a PR of mine 😅
I don't think this is really a requirement, though.
There was a problem hiding this comment.
There's also the
passthru.updateScript = nix-update-script { }, see the wiki article on it. I can't vouch for it as I haven't yet used it, only requested to use it on a PR of mine 😅I don't think this is really a requirement, though.
Thanks for mentioning the updateScript! Since this is the initial package submission, I'd prefer to keep it simple for now. I can look into adding the update script in a future PR once the basic package is merged.
Add Elgato Key Light CLI https://github.com/versality/keylight-cli
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.