Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ronin: 2.0.5 -> 2.1.0 #371132

Merged
merged 1 commit into from
Jan 13, 2025
Merged

ronin: 2.0.5 -> 2.1.0 #371132

merged 1 commit into from
Jan 13, 2025

Conversation

Ch1keen
Copy link
Member

@Ch1keen Ch1keen commented Jan 5, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lucasew
Copy link
Contributor

lucasew commented Jan 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371132


x86_64-linux

✅ 1 package built:
  • ronin

@Ch1keen Ch1keen force-pushed the ronin-2.1.0 branch 2 times, most recently from 5d44c7c to 0d78826 Compare January 8, 2025 13:56
@pbsds
Copy link
Member

pbsds commented Jan 8, 2025

could you please add version to the name, or split name into pname+version if supported?

@Ch1keen
Copy link
Member Author

Ch1keen commented Jan 13, 2025

Thank you for your review. I ended up with adding a line of version.

The ronin package was successfully built using nix-shell -I nixpkgs=. -p ronin --pure.

@pbsbot
Copy link

pbsbot commented Jan 13, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371132


x86_64-linux

✅ 1 package built:
  • ronin

@pbsds pbsds merged commit 4dc3772 into NixOS:master Jan 13, 2025
24 of 27 checks passed
@Ch1keen
Copy link
Member Author

Ch1keen commented Jan 15, 2025

Thank you for all reviewers.

It was also intended to address #351833.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants