-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mlibc: init at 5.0.0-unstable-2025-01-12 #371092
Draft
lzcunt
wants to merge
7
commits into
NixOS:master
Choose a base branch
from
lzcunt:mlibc/init
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+181
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
6.topic: lib
The Nixpkgs function library
10.rebuild-darwin: 11-100
10.rebuild-linux: 101-500
labels
Jan 5, 2025
lzcunt
changed the title
mlibc: init at 5.0.0-unstable-2025-01-02
mlibc: init at 5.0.0-unstable-2025-01-05
Jan 5, 2025
Previously gccWithoutTargetLibc was built with `langCC = false;`, which meant stdenvNoLibc had C++ support when not cross compiling or when the host platform toolchain is LLVM, but did not have C++ support when cross compiling for a non-Darwin and non-LLVM host platform. This patch fixes issues when cross compiling C++ packages built with stdenvNoLibc like LLVM libc and the mlibc package I'm (sanana) working on. Co-Authored-By: Artturin <[email protected]> Co-Authored-By: Arsen Arsenović <[email protected]>
lzcunt
added a commit
to lzcunt/nixpkgs
that referenced
this pull request
Jan 14, 2025
freesweep has a new version in development and it seems to be usable, let's update to it. I added myself as a maintainer and included a few patches to allow it to build with and without mlibc (which I'm working on in NixOS#371092).
lzcunt
added a commit
to lzcunt/nixpkgs
that referenced
this pull request
Jan 14, 2025
freesweep has a new version in development and it seems to be usable, let's update to it. I added myself as a maintainer and included a few patches to allow it to build with and without mlibc (which I'm working on in NixOS#371092).
13 tasks
Checking if openssl is a derivation requires evaluating stdenv.cc, which depends on mlibc when cross compiling to a mlibc platform, which depends on meson, which depends on Python. See previous commit 0070883 on why the recursion break happens in the Python expression.
In gcc, libsanitize is disabled because mlibc doesn't support libsanitize yet but upstream is working on it. Patches needed for gcc to support linux-mlibc targets are pulled from managarm's fork of gcc, patches only needed by managarm are not applied.
lzcunt
changed the title
mlibc: init at 5.0.0-unstable-2025-01-05
mlibc: init at 5.0.0-unstable-2025-01-12
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: lib
The Nixpkgs function library
6.topic: python
10.rebuild-darwin: 11-100
10.rebuild-linux: 101-500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mlibc is a portable C standard library by the managarm project. mlibc developers are interested in running a full linux distro on top of mlibc and in my opinion NixOS is a prime candidate. Having it in nixpkgs would also help developers using mlibc.
This is a draft PR because I need to build and test other architectures supported by mlibc on linux and there's a bug making mlibc's RTLD unable to find
libgcc_s.so.1
through RPATH. So feel free to review even tho this is a draft. bash works when built with mlibc. #370683 needs to be merged before this is merged.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.