-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: replace git
with gitMinimal
#370895
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
commented
Jan 4, 2025
github-actions
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
labels
Jan 4, 2025
github-actions
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 101-500
and removed
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
labels
Jan 4, 2025
nix-owners
bot
requested review from
06kellyjac,
7c6f434c,
aanderse,
anthonyroussel,
borisbabic,
Br1ght0ne,
centromere,
CobaltCause,
danc86,
developer-guy,
eljamm,
ericdallo,
fabaff,
figsoda and
FlafyDev
January 4, 2025 16:43
drupol
requested review from
GaetanLepage
and removed request for
FlafyDev and
eljamm
January 4, 2025 17:19
danc86
approved these changes
Jan 4, 2025
drupol
force-pushed
the
push-zqmppkmlywzl
branch
from
January 9, 2025 20:04
6c4555e
to
756d00c
Compare
Planning to merge this tomorrow morning if no objection. |
wegank
removed
the
12.approvals: 2
This PR was reviewed and approved by two reputable people
label
Jan 10, 2025
fcff431 |
Thanks for fixing it promptly ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
git
withgitMinimal
whengit init
is used in thecheckPhases
Why?
The footprint of
git
is approximately 3 times bigger thangitMinimal
. There's no need to download so much when we can do it with something smaller.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.