Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: replace git with gitMinimal #370895

Merged
merged 40 commits into from
Jan 10, 2025
Merged

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Jan 4, 2025

This PR:

  • Replace git with gitMinimal when git init is used in the checkPhases

Why?

The footprint of git is approximately 3 times bigger than gitMinimal. There's no need to download so much when we can do it with something smaller.

❯ nix build .#git
❯ nix path-info -Sh ./result
/nix/store/iwq58rpn6idjnxbnyjh351776qzvsd0r-git-2.47.0   317.3 MiB
❯ nix build .#gitMinimal
❯ nix path-info -Sh ./result
/nix/store/7998dljnnlk9yqpwnrrwwbhrikjkbai5-git-minimal-2.47.0   121.6 MiB

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 4, 2025
@nix-owners nix-owners bot requested a review from pinpox January 4, 2025 16:42
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 4, 2025
@drupol drupol requested review from GaetanLepage and removed request for FlafyDev and eljamm January 4, 2025 17:19
@drupol drupol force-pushed the push-zqmppkmlywzl branch from 6c4555e to 756d00c Compare January 9, 2025 20:04
@drupol drupol marked this pull request as ready for review January 9, 2025 20:06
@drupol
Copy link
Contributor Author

drupol commented Jan 9, 2025

Planning to merge this tomorrow morning if no objection.

@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 10, 2025
@drupol drupol merged commit fd862b3 into NixOS:staging Jan 10, 2025
25 of 26 checks passed
@drupol drupol deleted the push-zqmppkmlywzl branch January 10, 2025 07:12
@trofi
Copy link
Contributor

trofi commented Jan 11, 2025

fcff431 pre-commit: replace git with gitMinimal caused a minor eval test failre. Proposed a fix as:

@drupol
Copy link
Contributor Author

drupol commented Jan 11, 2025

fcff431 pre-commit: replace git with gitMinimal caused a minor eval test failre. Proposed a fix as:

Thanks for fixing it promptly !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants