Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godot3: fix PIE hardening #370627

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FliegendeWurst
Copy link
Member

@FliegendeWurst FliegendeWurst commented Jan 3, 2025

In preparation for #205031

Things done

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jan 3, 2025
@lucasew
Copy link
Contributor

lucasew commented Jan 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370627


x86_64-linux

✅ 23 packages built:
  • _4d-minesweeper
  • find-billy
  • godot3
  • godot3-debug-server
  • godot3-export-templates
  • godot3-headless
  • godot3-headless.dev
  • godot3-headless.man
  • godot3-mono
  • godot3-mono-debug-server
  • godot3-mono-export-templates
  • godot3-mono-headless
  • godot3-mono-headless.dev
  • godot3-mono-headless.man
  • godot3-mono-server
  • godot3-mono.dev
  • godot3-mono.man
  • godot3-server
  • godot3.dev
  • godot3.man
  • lorien
  • material-maker
  • oh-my-git

@LunNova
Copy link
Member

LunNova commented Jan 5, 2025

Failing github check was it trying to tag owners for review:

[{"id":731734101,"node_id":"MDU6TGFiZWw3MzE3MzQxMDE=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%2011-100","name":"10.rebuild-linux: 11-100","color":"fbca04","default":false,"description":null},{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false,"description":"This PR does not cause any packages to rebuild on Darwin"}]{"message":"Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the NixOS/nixpkgs repository.","documentation_url":"https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request","status":"422"}

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 5, 2025
@FliegendeWurst FliegendeWurst marked this pull request as draft January 11, 2025 23:30
@FliegendeWurst FliegendeWurst changed the title godot3: disable PIE hardening godot3: fix PIE hardening Jan 12, 2025
@FliegendeWurst FliegendeWurst marked this pull request as ready for review January 12, 2025 13:59
@FliegendeWurst
Copy link
Member Author

PR updated to fix the build issue instead of disabling PIE.
This seems to be a common error so I've added the error message + fix to the tracking issue.

@nix-owners nix-owners bot requested a review from Rotaerk January 12, 2025 14:06
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants