Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] nixos/kmonad: create determinate symlinks #370329

Merged

Conversation

jian-lin
Copy link
Contributor

@jian-lin jian-lin commented Jan 2, 2025

(cherry picked from commit 9695e75)

The 25.05 release note is manually removed.

#370053

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

(cherry picked from commit 9695e75)

The 25.05 release note is manually removed.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 2, 2025
@jian-lin jian-lin changed the title nixos/kmonad: create determinate symlinks [Backport release-24.11] nixos/kmonad: create determinate symlinks Jan 2, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 2, 2025
@r-vdp
Copy link
Contributor

r-vdp commented Jan 2, 2025

If the backport failure was because of the format commit, maybe we should add a commit to format the file so that future backports won't fail as well?

@jian-lin
Copy link
Contributor Author

jian-lin commented Jan 2, 2025

The backport CI check fails because there is no rl-25.05.section.md file.

Not sure what you mean by format.

@jian-lin jian-lin merged commit 239fb3f into NixOS:release-24.11 Jan 2, 2025
29 of 31 checks passed
@jian-lin jian-lin deleted the pr/kmonad-manual-backport-370053 branch January 2, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants