Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lomiri.*: Add mesa.llvmpipeHook, re-allow affected test(s) #369525

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions pkgs/desktops/lomiri/applications/lomiri-clock-app/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
lomiri-sounds,
lomiri-ui-toolkit,
makeWrapper,
mesa,
pkg-config,
qtbase,
qtdeclarative,
Expand Down Expand Up @@ -77,6 +78,7 @@ stdenv.mkDerivation (finalAttrs: {
];

nativeCheckInputs = [
mesa.llvmpipeHook # ShapeMaterial needs an OpenGL context: https://gitlab.com/ubports/development/core/lomiri-ui-toolkit/-/issues/35
qtdeclarative # qmltestrunner
xvfb-run
];
Expand All @@ -87,20 +89,6 @@ stdenv.mkDerivation (finalAttrs: {
(lib.cmakeBool "CLICK_MODE" false)
(lib.cmakeBool "INSTALL_TESTS" false)
(lib.cmakeBool "USE_XVFB" true)
(lib.cmakeFeature "CMAKE_CTEST_ARGUMENTS" (
lib.concatStringsSep ";" [
# Exclude tests
"-E"
(lib.strings.escapeShellArg "(${
lib.concatStringsSep "|" [
# Runs into ShapeMaterial codepath in lomiri-ui-toolkit which needs OpenGL, see LUITK for details
"^AlarmLabel"
"^AlarmRepeat"
"^AlarmSound"
]
})")
]
))
];

doCheck = stdenv.buildPlatform.canExecute stdenv.hostPlatform;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
lomiri-settings-components,
lomiri-ui-toolkit,
maliit-keyboard,
mesa,
pkg-config,
polkit,
python3,
Expand Down Expand Up @@ -136,6 +137,7 @@ stdenv.mkDerivation (finalAttrs: {

nativeCheckInputs = [
dbus
mesa.llvmpipeHook # ShapeMaterial needs an OpenGL context: https://gitlab.com/ubports/development/core/lomiri-ui-toolkit/-/issues/35
(python3.withPackages (ps: with ps; [ python-dbusmock ]))
xvfb-run
];
Expand All @@ -151,19 +153,6 @@ stdenv.mkDerivation (finalAttrs: {
cmakeFlags = [
(lib.cmakeBool "ENABLE_LIBDEVICEINFO" true)
(lib.cmakeBool "ENABLE_TESTS" finalAttrs.finalPackage.doCheck)
(lib.cmakeFeature "CMAKE_CTEST_ARGUMENTS" (
lib.concatStringsSep ";" [
# Exclude tests
"-E"
(lib.strings.escapeShellArg "(${
lib.concatStringsSep "|" [
# Hits OpenGL context issue inside lomiri-ui-toolkit, see derivation of that on details
"^testmouse"
"^tst_notifications"
]
})")
]
))
];

# The linking for this normally ignores missing symbols, which is inconvenient for figuring out why subpages may be
Expand Down
5 changes: 2 additions & 3 deletions pkgs/desktops/lomiri/applications/morph-browser/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
lomiri-content-hub,
lomiri-ui-extras,
lomiri-ui-toolkit,
mesa,
pkg-config,
qqc2-suru-style,
qtbase,
Expand Down Expand Up @@ -90,6 +91,7 @@ stdenv.mkDerivation (finalAttrs: {
];

nativeCheckInputs = [
mesa.llvmpipeHook # ShapeMaterial needs an OpenGL context: https://gitlab.com/ubports/development/core/lomiri-ui-toolkit/-/issues/35
xvfb-run
];

Expand All @@ -102,9 +104,6 @@ stdenv.mkDerivation (finalAttrs: {
lib.concatStringsSep "|" [
# Don't care about linter failures
"^flake8"

# Runs into ShapeMaterial codepath in lomiri-ui-toolkit which needs OpenGL, see LUITK for details
"^tst_QmlTests"
]
})")
]
Expand Down
4 changes: 2 additions & 2 deletions pkgs/desktops/lomiri/qml/lomiri-ui-extras/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
cups,
exiv2,
lomiri-ui-toolkit,
mesa,
pam,
pkg-config,
qtbase,
Expand Down Expand Up @@ -48,6 +49,7 @@ stdenv.mkDerivation (finalAttrs: {
];

nativeCheckInputs = [
mesa.llvmpipeHook # ShapeMaterial needs an OpenGL context: https://gitlab.com/ubports/development/core/lomiri-ui-toolkit/-/issues/35
qtdeclarative # qmltestrunner
xvfb-run
];
Expand All @@ -66,8 +68,6 @@ stdenv.mkDerivation (finalAttrs: {
"-E"
(lib.strings.escapeShellArg "(${
lib.concatStringsSep "|" [
# tst_busy_indicator runs into a codepath in lomiri-ui-toolkit that expects a working GL context
"^tst_busy_indicator"
# Photo & PhotoImageProvider Randomly fail, unsure why
"^tst_PhotoEditorPhoto"
]
Expand Down

This file was deleted.

4 changes: 2 additions & 2 deletions pkgs/desktops/lomiri/qml/lomiri-ui-toolkit/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
gdb,
glib,
lttng-ust,
mesa,
perl,
pkg-config,
python3,
Expand Down Expand Up @@ -60,8 +61,6 @@ stdenv.mkDerivation (finalAttrs: {
];

patches = [
./2001-Mark-problematic-tests.patch

(substituteAll {
src = ./2002-Nixpkgs-versioned-QML-path.patch.in;
name = "2002-Nixpkgs-versioned-QML-path.patch";
Expand Down Expand Up @@ -149,6 +148,7 @@ stdenv.mkDerivation (finalAttrs: {
dbus-test-runner
dpkg # `dpkg-architecture -qDEB_HOST_ARCH` response decides how tests are run
gdb
mesa.llvmpipeHook # ShapeMaterial needs an OpenGL context: https://gitlab.com/ubports/development/core/lomiri-ui-toolkit/-/issues/35
xvfb-run
];

Expand Down
Loading