Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.05] signal-desktop: 7.33.0 -> 7.36.0, signal-desktop(aarch64-linux): 7.33.0 -> 7.36.0 #369251

Merged
merged 5 commits into from
Dec 30, 2024
Merged

[24.05] signal-desktop: 7.33.0 -> 7.36.0, signal-desktop(aarch64-linux): 7.33.0 -> 7.36.0 #369251

merged 5 commits into from
Dec 30, 2024

Conversation

teutat3s
Copy link
Member

@teutat3s teutat3s commented Dec 29, 2024 •
edited
Loading

Manual backport of #364691 and friends. Probably the last for 24.05.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Gliczy @teutat3s
signal-desktop: 7.33.0 -> 7.34.0
fe98cd4 
(cherry picked from commit 04b5462)
@Gliczy @teutat3s
signal-desktop(aarch64-linux): 7.33.0 -> 7.34.0
18aa68d 
(cherry picked from commit 14b412b)
@Gliczy @teutat3s
signal-desktop: 7.34.0 -> 7.35.0 (NixOS#361881)
3e8d4d5 
* signal-desktop: 7.34.0 -> 7.35.0

(cherry picked from commit 88f9f6f)
@Gliczy @teutat3s
signal-desktop: 7.35.0 -> 7.36.0
995165d 
(cherry picked from commit 60bd0ea)
@Gliczy @teutat3s
signal-desktop(aarch64-linux): 7.34.0 -> 7.36.0
8feaccd 
(cherry picked from commit 4c24a07)
@teutat3s teutat3s added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 29, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 30, 2024
@teutat3s
Copy link
Member Author

Manually running the tests with nix build -f . nixosTests.signal-desktop.driverInteractive shows signal-desktop starts fine. I suspect a flaky test, which has happened on 24.05 before.

@emilazy emilazy merged commit c4639d2 into NixOS:release-24.05 Dec 30, 2024
36 of 39 checks passed
@emilazy
Copy link
Member

emilazy commented Dec 30, 2024

Thanks for seeing Signal on 24.05 through to EOL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gliczy Gliczy Awaiting requested review from Gliczy

@Mic92 Mic92 Awaiting requested review from Mic92

@urandom2 urandom2 Awaiting requested review from urandom2

@bkchr bkchr Awaiting requested review from bkchr

@emilazy emilazy Awaiting requested review from emilazy

@equirosa equirosa Awaiting requested review from equirosa

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teutat3s @emilazy @Gliczy