-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kakasi: avoid an implicit declaration of exit
#368909
Conversation
pkgs/by-name/ka/kakasi/avoid-an-implicit-declaration-of-exit.patch
Outdated
Show resolved
Hide resolved
pkgs/by-name/ka/kakasi/avoid-an-implicit-declaration-of-exit.patch
Outdated
Show resolved
Hide resolved
Better to:
|
|
this fixes the build of me. I've discovered the software thanks to this PR. As a sidenote, this PR could be an occasion to fix the warning:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
This caused the following false alarm: ``` error: can not use EUC-JP or UTF-8 encoding on iconv ``` See https://git.launchpad.net/ubuntu/+source/kakasi/commit/?h=applied/ubuntu/plucky&id=08f53a5.
This caused the following false alarm:
See https://git.launchpad.net/ubuntu/+source/kakasi/commit/?h=applied/ubuntu/plucky&id=08f53a5.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.