-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cockpit: 330 -> 331 #368886
cockpit: 330 -> 331 #368886
Conversation
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
fde88e3
to
44812cd
Compare
The new iteration is just nixfmt |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try adding versionCheckHook
(see typst/package.nix
for an example) ?
Also, for meta
:
- remove
with lib;
, - Add `changelog = "https://cockpit-project.org/blog/cockpit-${finalAttrs.version}.html";
I haven't looked at the module.
Signed-off-by: lucasew <[email protected]>
93ecd8e
to
af9751f
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust you on the nixos module aspect
Thanks for addressing all my comments :) |
Going to backport this as the stable version is also broken |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-368886-to-release-24.11 origin/release-24.11
cd .worktree/backport-368886-to-release-24.11
git switch --create backport-368886-to-release-24.11
git cherry-pick -x b06a23a6148f79c5fdf806655319472f7313b9c4 44812cdb98d87f011caaad847cca46f071a74c59 af9751f3fcdca851d822f5ca0c8a725fe98d4cb7 |
Backport PR #369266 |
Fixes: #367053
Basically, cockpit was having some FHS assuming issues. This PR bumps to the latest version and fixes them.
When merged, this should be backported because stable is also broken.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.