Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cockpit: 330 -> 331 #368886

Merged
merged 3 commits into from
Dec 29, 2024
Merged

cockpit: 330 -> 331 #368886

merged 3 commits into from
Dec 29, 2024

Conversation

lucasew
Copy link
Contributor

@lucasew lucasew commented Dec 28, 2024

Fixes: #367053

  • cockpit: 330 -> 331
  • tests/cockpit: each wait with its own waiter, treat /nonexistent case

Basically, cockpit was having some FHS assuming issues. This PR bumps to the latest version and fixes them.

When merged, this should be backported because stable is also broken.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 28, 2024
@lucasew lucasew force-pushed the 20241228-cockpit-fix branch from fde88e3 to 44812cd Compare December 28, 2024 19:10
@lucasew
Copy link
Contributor Author

lucasew commented Dec 28, 2024

The new iteration is just nixfmt

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 28, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/cockpit-dashboard-management-interface-package-does-not-work-properly/57403/16

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try adding versionCheckHook (see typst/package.nix for an example) ?

Also, for meta:

I haven't looked at the module.

pkgs/by-name/co/cockpit/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cockpit/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cockpit/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cockpit/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cockpit/package.nix Outdated Show resolved Hide resolved
@lucasew lucasew force-pushed the 20241228-cockpit-fix branch from 93ecd8e to af9751f Compare December 29, 2024 22:12
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Dec 29, 2024
@lucasew lucasew requested a review from GaetanLepage December 29, 2024 22:23
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368886


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • cockpit

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • cockpit

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you on the nixos module aspect

@GaetanLepage
Copy link
Contributor

Thanks for addressing all my comments :)

@GaetanLepage GaetanLepage merged commit 3e7585f into NixOS:master Dec 29, 2024
24 of 25 checks passed
@lucasew lucasew added the backport release-24.11 Backport PR automatically label Dec 30, 2024
@lucasew
Copy link
Contributor Author

lucasew commented Dec 30, 2024

Going to backport this as the stable version is also broken

@lucasew lucasew deleted the 20241228-cockpit-fix branch December 30, 2024 00:15
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 30, 2024

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-368886-to-release-24.11 origin/release-24.11
cd .worktree/backport-368886-to-release-24.11
git switch --create backport-368886-to-release-24.11
git cherry-pick -x b06a23a6148f79c5fdf806655319472f7313b9c4 44812cdb98d87f011caaad847cca46f071a74c59 af9751f3fcdca851d822f5ca0c8a725fe98d4cb7

@lucasew
Copy link
Contributor Author

lucasew commented Dec 30, 2024

Backport PR #369266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: in cockpit supporting applications cannot be used in cockpit because libexecdir cannot be found.
4 participants