Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.fs: re-add setuptools #368857

Merged
merged 1 commit into from
Jan 6, 2025
Merged

python312Packages.fs: re-add setuptools #368857

merged 1 commit into from
Jan 6, 2025

Conversation

Pandapip1
Copy link
Contributor

See issue raised at #349608 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Pandapip1 Pandapip1 requested a review from fabaff December 28, 2024 16:32
@Pandapip1
Copy link
Contributor Author

CC @eclairevoyant

@ofborg ofborg bot requested a review from lovek323 December 28, 2024 21:37
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 29, 2024
fabaff
fabaff approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@Pandapip1 Pandapip1 added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 29, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2173

@ShamrockLee
Copy link
Contributor

From the discussion thread #349608 (comment), it seems like the issue would only be shown when building some dependent packages (reverse dependencies). How about adding one of them to this package's passthru.tests?

@wegank wegank removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Dec 30, 2024
@vcunat vcunat merged commit b9c7ebc into NixOS:staging Jan 6, 2025
45 of 46 checks passed
@Pandapip1 Pandapip1 deleted the fix-python-fs branch January 6, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclairevoyant eclairevoyant eclairevoyant approved these changes

@fabaff fabaff fabaff approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Pandapip1 @nixos-discourse @ShamrockLee @fabaff @eclairevoyant @vcunat @wegank