Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers: add damidoug #368618

Closed
wants to merge 1 commit into from
Closed

Conversation

damidoug
Copy link
Contributor

@damidoug damidoug commented Dec 27, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 27, 2024
@drupol
Copy link
Contributor

drupol commented Dec 29, 2024

Hello,

Thank you for your request.

Could you please provide some context or motivation behind your request to be added to the maintainer list? It would be helpful for us to understand how this aligns with your intentions or contributions to the project.

In my opinion, it might be more effective to create a PR that demonstrates why being included in the maintainer list is relevant. For instance:

  • Are you planning to contribute to nixpkgs?
  • Do you intend to adopt and maintain specific packages?

If your goal is to adopt packages, there's no need for a separate PR for this request. Instead, you can include a commit in a PR where it's clear which packages you'd like to maintain.

Please note that this is not about discouraging new contributors, on the contrary! We value new maintainers, and some contextual information will help us streamline the process and support your contributions effectively.

Thank you.

@drupol drupol closed this Dec 29, 2024
@damidoug
Copy link
Contributor Author

Hi @drupol,

I hope you're doing well.

Thank you for your feedback. I've already created a couple of PRs that are currently waiting for review, and I actively use Nix on both macOS (Darwin) and Linux. My experience with Nix has given me insights into packages that I can add, update, or improve.

At the moment, I have two PRs open (#368631 - #368638), and I plan to contribute more soon. I believe I can make meaningful contributions to the Nix community and would like to take on a more active role as a maintainer.

Let me know if there's anything specific you'd like me to demonstrate or clarify further.

Thank you.

@drupol
Copy link
Contributor

drupol commented Dec 29, 2024

Hello !

Thanks for your constructive feedback, it's a bit sensible to explain that and I'm glad you didn't took it personally.

Do you think it would be possible to cherry pick the commit from this PR in the PRs you're working on? So that we review both of them at the same time?

By the way, welcome to the Nix community!

Thank you!

@damidoug
Copy link
Contributor Author

Hi!

Thank you for your kind and constructive feedback. I’ve gone ahead and cherry-picked the commit from this PR into the other two PRs as suggested.

By the way, I truly appreciate the warm welcome to the Nix community. 😊

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants