nixos/homer: init #368594
Open
nixos/homer: init #368594
+259
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Stunkymonkey
force-pushed
the
nixos-homer
branch
from
2bfb232 to
c901971
Compare
Closed
Stunkymonkey
force-pushed
the
nixos-homer
branch
3 times, most recently
from
ba4521a to
169da2a
Compare
Stunkymonkey
force-pushed
the
nixos-homer
branch
from
169da2a to
7bda6be
Compare
christoph-heiss
suggested changes
Jan 2, 2025
Comment on lines
47
to
59
| finalDrv = lib.mkOption { | ||
| readOnly = true; | ||
| default = if cfg.settings != { } then homerPackageWithConfig else cfg.package; | ||
| defaultText = '' | ||
| if cfg.settings != {} | ||
| then homerPackageWithConfig | ||
| else cfg.package; | ||
| ''; | ||
| type = lib.types.package; | ||
| description = '' | ||
| Final derivation containing the fully built static files | ||
| ''; | ||
| }; |
There was a problem hiding this comment.
Instead of building a complete separate package with the config in it - how about just serving the file directly at the correct endpoint?
E.g. for nginx I'm currently using something like this:
locations."= /assets/config.yml" = {
root = "${dirOf configFile}";
tryFiles = "/${baseNameOf configFile} =404";
extraConfig = ''
expires -1;
'';
};where configFile is just
configFile =
pkgs.writeText "homer-config.yml" (generators.toYAML { } cfg.settings);There was a problem hiding this comment.
please look again
| A dead simple static HOMepage for your servER to keep your services on hand, from a simple yaml configuration file. | ||
| ''; | ||
|
|
||
| virtualHost = { |
There was a problem hiding this comment.
A location (or something like subPath) option would be great, for serving homer on a subdirectory path.
There was a problem hiding this comment.
please look again
Stunkymonkey
force-pushed
the
nixos-homer
branch
from
7bda6be to
bf80a77
Compare
h7x4
added
8.has: module (new)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.