-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnupg24: add freepg patches #368275
gnupg24: add freepg patches #368275
Conversation
0d1368a
to
447c3ce
Compare
570332a
to
addd12c
Compare
ca54d44
to
7ac027e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested this yet but 👍 on introducing the freepg patches.
Add patches to GnuPG 2.4 from FreePG, a common resource for GnuPG downstream packagers to track, maintain, and apply commonly-used patches for GnuPG that have been refused by upstream. The purpose of adding these patches to nixpkgs is to ensure compatibility with other OpenPGP tools. https://gitlab.com/freepg/gnupg/
7ac027e
to
0d7cdd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sad that this is necessary, but I agree that it’s a good idea. I’ve confirmed the build on x86_64-darwin
(rebased on top of master
). Two non‐blocking comments for the future.
domain = "gitlab.com"; | ||
owner = "freepg"; | ||
repo = "gnupg"; | ||
rev = "541772915dc4ec832c37f85bc629a22051f0e8f7"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream have tags corresponding to GnuPG releases; it would be nice if we could convince them to also tag the branch with the patch files in them in future. Or we could just source directly from their patched tags.
"0002-gpg-accept-subkeys-with-a-good-revocation-but-no-sel.patch" | ||
"0003-gpg-allow-import-of-previously-known-keys-even-witho.patch" | ||
"0004-tests-add-test-cases-for-import-without-uid.patch" | ||
"0005-gpg-drop-import-clean-from-default-keyserver-import-.patch" | ||
"0006-Do-not-use-OCB-mode-even-if-AEAD-OCB-key-preference-.patch" | ||
"0007-Revert-the-introduction-of-the-RFC4880bis-draft-into.patch" | ||
"0008-avoid-systemd-deprecation-warning.patch" | ||
"0009-Add-systemd-support-for-keyboxd.patch" | ||
"0010-doc-Remove-profile-and-systemd-example-files.patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t know if globs work here, but if not perhaps we could do it manually in postPatch
instead, to ensure that we never miss a new patch.
Add patches to GnuPG 2.4 from FreePG, a common resource for GnuPG downstream packagers to track, maintain, and apply commonly-used patches for GnuPG that have been refused by upstream.
The purpose of adding these patches to nixpkgs is to ensure compatibility with other OpenPGP tools.
https://gitlab.com/freepg/gnupg/
Arch Linux is also doing the same:
https://gitlab.archlinux.org/archlinux/packaging/packages/gnupg/-/merge_requests/8
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.