Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raycast: add archBuild, refactor passthru.updateScript, 1.88.3 -> 1.88.4 #368171

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

DontEatOreo
Copy link
Member

@DontEatOreo DontEatOreo commented Dec 25, 2024

I was looking at the raycast cask code and saw that they were actually
two distinct versions (arm and x86_64):

https://github.com/Homebrew/homebrew-cask/blob/aa99ed034780e405c45e59c8e4c02e272924721d/Casks/r/raycast.rb#L13

So I'm updating the Nix derivation to also be able to use either version
instead of just the "universal" one

Now for the passthru.updateScript, since I need sed to update the
hashes, I might as well just use it to update the version too and not
depend on common-updater-scripts just to update a single string

Closes #369003

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 25, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 labels Dec 25, 2024
@stepbrobd
Copy link
Member

tbh im a bit reluctant on this pr
the universal build barely adds anything to arm/x86 machines after installation
making it architecture specific adds unnecessary complexity to both package definition and update script

@DontEatOreo
Copy link
Member Author

I would argue that the added complexity is very minimal, and since we can't build from source, I think it's worthwhile to at least provide platform-specific binaries instead of bundled ones

pkgs/by-name/ra/raycast/package.nix Outdated Show resolved Hide resolved
@DontEatOreo
Copy link
Member Author

Thanks a lot for the review @stepbrobd!

@stepbrobd
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368171


aarch64-darwin

✅ 1 package built:
  • raycast

@stepbrobd
Copy link
Member

Thanks a lot for the review @stepbrobd!

a bit late but merry christmas (if u celebrate)
also a bit early but happy new year 😂

@stepbrobd stepbrobd added 8.has: package (update) This PR updates a package to a newer version 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 28, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2169

@DontEatOreo
Copy link
Member Author

a bit late but merry christmas (if u celebrate)
also a bit early but happy new year 😂

Merry Christmas to you as well if you celebrate (and yes, I do; it was pretty nice this year 😄)

And I also wish you a Happy New Year in advance too 😂

@ofborg ofborg bot requested a review from stepbrobd December 28, 2024 05:27
@DontEatOreo DontEatOreo mentioned this pull request Dec 29, 2024
13 tasks
@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368171


x86_64-darwin

✅ 1 package built:
  • raycast

aarch64-darwin

✅ 1 package built:
  • raycast

@khaneliman khaneliman merged commit 183c8f0 into NixOS:master Dec 29, 2024
52 of 53 checks passed
@DontEatOreo DontEatOreo deleted the refactor-raycast branch December 29, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants