-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raycast: add archBuild
, refactor passthru.updateScript
, 1.88.3 -> 1.88.4
#368171
Conversation
tbh im a bit reluctant on this pr |
I would argue that the added complexity is very minimal, and since we can't build from source, I think it's worthwhile to at least provide platform-specific binaries instead of bundled ones |
77dd364
to
3d4cb9f
Compare
3d4cb9f
to
625e9b0
Compare
Thanks a lot for the review @stepbrobd! |
|
a bit late but merry christmas (if u celebrate) |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2169 |
Merry Christmas to you as well if you celebrate (and yes, I do; it was pretty nice this year 😄) And I also wish you a Happy New Year in advance too 😂 |
|
I was looking at the
raycast
cask code and saw that they were actuallytwo distinct versions (
arm
andx86_64
):https://github.com/Homebrew/homebrew-cask/blob/aa99ed034780e405c45e59c8e4c02e272924721d/Casks/r/raycast.rb#L13
So I'm updating the Nix derivation to also be able to use either version
instead of just the "universal" one
Now for the
passthru.updateScript
, since I needsed
to update thehashes, I might as well just use it to update the version too and not
depend on
common-updater-scripts
just to update a single stringCloses #369003
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.