haskellPackages.libtorch-ffi: Fix the link to libtorch #367998

junjihashimoto · 2024-12-24T20:45:42Z

Fix the broken hasktorch.

Things done

Add a 👍 reaction to pull requests you find important.

junjihashimoto · 2024-12-25T01:39:05Z

Can we make changes like this PR in maintainers/scripts/haskell?

SomeoneSerge · 2024-12-25T17:19:00Z

pkgs/development/haskell-modules/hackage-packages.nix

I'm not familiar with haskell packages infra really, but the first line of the file says: /* hackage-packages.nix is auto-generated by hackage2nix -- DO NOT EDIT MANUALLY! */. I presume there should be some other place for applying overrides?

Maybe this is the place? pkgs/development/haskell-modules/replacements-by-name/

Maybe pkgs/development/haskell-modules/configuration-nix.nix is the better tool, I see that libGL related patches and configurations are applied there

Thank you for your review! I'll check the place.

SomeoneSerge · 2024-12-25T17:20:45Z

pkgs/development/haskell-modules/hackage-packages.nix

+       configureFlags = [
+         "--extra-include-dirs=${lib.getDev pkgs.libtorch-bin}/include/torch/csrc/api/include"
+       ]  ++ lib.optionals pkgs.config.cudaSupport [ "-f cuda" ];
+     }) ({
+       c10 = pkgs.libtorch-bin;
+       torch_cpu = pkgs.libtorch-bin;
+       torch = pkgs.libtorch-bin;
+     } // lib.optionalAttrs (pkgs.config.cudaSupport) {
+       torch_cuda = pkgs.libtorch-bin;
+     });
+


Any particular reason to choose the wheel package over the real build from python3Packages.torch?

AFAIK python3Packages.torch uses pre-cxx11 ABI. It needs the extra option for compiling and linking.
So it uses the libtorch.

It is related to this issue.
pytorch/pytorch#102142
https://discuss.pytorch.org/t/as-i-downloaded-libtorch-i-have-two-choices-pre-cxx11-abi-and-cxx11-abi-the-question-is-that-what-is-the-difference-between-them/159473

AFAIK python3Packages.torch uses pre-cxx11 ABI. It needs the extra option for compiling and linking.
So it uses the libtorch.

Huh. I wonder if we should introduce another attribute for cxx11-abi source-built torch, or just make cxx11-abi the default. "There are no stupid questions", but: could the latter cause symbol collisions with other native extensions? The new attribute, otoh, could be named libtorch to contrast it with libtorch-bin. We definitely should do one of the two, but not in this PR

For other native extensions of pytorch, we need to add a cmake option not to use cxx11-abi, otherwise symbol conflicts will occur.
gcc and clang use cxx11-abi by default.
I think it's good that cxx11-abi libtorch is the default, because users don't have to specify any options.
I don't think libtorch users are also native extension users, so I'm not sure if the two options are necessary.

For other native extensions of pytorch

Well yes we use extensions like torchaudio with the same variant of pytorch we compile it against, incl. the same version of the cuda stack. But I rather meant, other extensions like opencv4, zeromq, etc, etc that use libstdc++.

Bottom line: would be nice for us at some point to investigate moving hasktorch from libtorch-bin to source-build torch

pkgs/development/haskell-modules/hackage-packages.nix

sternenseemann · 2024-12-26T17:02:02Z

Indeed, hackage-packages.nix may not be edited manually. You can re do your PR based on the haskell-updates branch where haskellPackages.hasktorch already points to the 0.2.1.1 version. Small modifications and fixes can be done via overrides in configuration-common.nix (for temporary workarounds) and/or configuration-nix.nix (for fixes that will always be necessary in nix(pkgs)). There are also platform and compiler specific files if need be.

junjihashimoto · 2024-12-28T08:53:50Z

@SomeoneSerge @sternenseemann Thank you for great help!
It moved to configuration-nix.nix.
For now, hasktorch in the hackage is 0.2.0.1 not 0.2.1.1, so I updated the version in configuration-nix.nix.
In my environment, it works on both macos and linux with CUDA.

[junji-hashimoto@nixos:~/git/nixpkgs]$ nix repl
Welcome to Nix 2.18.2. Type :? for help.

nix-repl> :l .
Added 23376 variables.

nix-repl> :u haskellPackages.ghcWithPackages (pkgs: with pkgs; [hasktorch])

[nix-shell:~/git/nixpkgs]$ ghci
GHCi, version 9.6.6: https://www.haskell.org/ghc/  :? for help
ghci> import Torch
ghci> a0 = toCUDA $ ones' [3,3]
ghci> a0 * a0
Tensor Float [3,3] [[ 1.0000   ,  1.0000   ,  1.0000   ],
                    [ 1.0000   ,  1.0000   ,  1.0000   ],
                    [ 1.0000   ,  1.0000   ,  1.0000   ]]

pkgs/development/haskell-modules/configuration-nix.nix

sternenseemann · 2024-12-28T12:24:02Z

I assume 0.2.1.1 fixes some issue 0.2.0.1 still exhibits? I think the manual upgrades will be obsolete soon, we'll have to bump hackage again soon for unrelated reasons.

junjihashimoto · 2024-12-28T22:10:46Z

The 0.2.0.1 has an issue of cabal file and no support for Apple GPU.

junjihashimoto · 2024-12-28T22:17:16Z

It might be better to remove the version and wait for the update. For now, the test will fail though.

junjihashimoto · 2024-12-28T22:36:16Z

It removed the versions of hasktorch and libtorch-ffi.

maralorn · 2024-12-31T16:18:01Z

pkgs/development/haskell-modules/configuration-darwin.nix

@@ -388,6 +388,10 @@ self: super: ({
  http-reverse-proxy = dontCheck super.http-reverse-proxy;
  servant-auth-server = dontCheck super.servant-auth-server;

+  sysinfo = overrideCabal (orig: {
+    doCheck = true;


There are doCheck / dontCheck helpers in haskell.lib.

Also is this a bitflip? Don’t you want to disable the test?

I think this should be sysinfo = dontCheck super.sysinfo here, as it used to be doCheck = !…isDarwin.

@maralorn @sternenseemann
It was wrong. Thanks for pointing that out. I've fixed it.

…properly on the sandbox of macOS.

sternenseemann · 2025-01-17T18:20:07Z

@junjihashimoto In #371032, haskell.packages.ghc96.hasktorch works again (though it is incorrectly marked as broken currently). Unfortunately, we got an unlucky timing and don't have libtorch-ffi-helper >= 2.0.0.1 which would also support GHC 9.8 (which is the new default).

junjihashimoto · 2025-01-18T08:00:56Z

@sternenseemann
The latest versions of hasktorch-0.2.1.2, libtorch-ffi-2.0.1.2, and libtorch-ffi-helper-2.0.0.1 support ghc9.8.
https://github.com/hasktorch/hasktorch/pull/718/files

junjihashimoto · 2025-01-18T08:02:33Z

I will make it possible to build hasktorch at the nightly stage before the LTS is released.

sternenseemann · 2025-01-18T11:16:51Z

@sternenseemann The latest versions of hasktorch-0.2.1.2, libtorch-ffi-2.0.1.2, and libtorch-ffi-helper-2.0.0.1 support ghc9.8. https://github.com/hasktorch/hasktorch/pull/718/files

Yes, I saw that! I've made a note to remove the broken flag when we have that version. hasktorch can be used on the haskell-updates branch now via GHC 9.6: d5ca2c9

github-actions bot added the 6.topic: haskell label Dec 24, 2024

junjihashimoto changed the title ~~haskellPackages.hasktorch: 0.0.1.0 -> 0.2.1.0~~ haskellPackages.hasktorch: 0.0.1.0 -> 0.2.1.1 Dec 24, 2024

nix-owners bot requested review from maralorn and sternenseemann December 24, 2024 20:47

junjihashimoto force-pushed the feature/hasktorch branch from e250f25 to 3107945 Compare December 24, 2024 20:47

github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 24, 2024

junjihashimoto force-pushed the feature/hasktorch branch from 3107945 to 9dceca0 Compare December 25, 2024 01:32

ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Dec 25, 2024

SomeoneSerge reviewed Dec 25, 2024

View reviewed changes

pkgs/development/haskell-modules/hackage-packages.nix Outdated Show resolved Hide resolved

junjihashimoto force-pushed the feature/hasktorch branch from 9dceca0 to 10fafcc Compare December 28, 2024 08:46

github-actions bot added the 8.has: documentation This PR adds or changes documentation label Dec 28, 2024

junjihashimoto changed the base branch from master to haskell-updates December 28, 2024 08:47

github-actions bot removed the 8.has: documentation This PR adds or changes documentation label Dec 28, 2024

junjihashimoto changed the title ~~haskellPackages.hasktorch: 0.0.1.0 -> 0.2.1.1~~ haskellPackages.hasktorch: 0.2.0.1 -> 0.2.1.1 Dec 28, 2024

github-actions bot added 10.rebuild-darwin: 5001+ 10.rebuild-linux: 5001+ and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 28, 2024

junjihashimoto force-pushed the feature/hasktorch branch from 10fafcc to ca8b8a8 Compare December 28, 2024 09:05

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 28, 2024

ofborg bot removed 10.rebuild-darwin: 5001+ 10.rebuild-linux: 5001+ labels Dec 28, 2024

sternenseemann reviewed Dec 28, 2024

View reviewed changes

pkgs/development/haskell-modules/configuration-nix.nix Outdated Show resolved Hide resolved

haskellPackages.libtorch-ffi: Fix the link to libtorch

ca85403

junjihashimoto force-pushed the feature/hasktorch branch from ca8b8a8 to b2fb84e Compare December 28, 2024 22:28

junjihashimoto changed the title ~~haskellPackages.hasktorch: 0.2.0.1 -> 0.2.1.1~~ haskellPackages.libtorch-ffi: Fix the link to libtorch Dec 28, 2024

github-actions bot removed 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 28, 2024

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 1-10 labels Dec 29, 2024

maralorn reviewed Dec 31, 2024

View reviewed changes

haskellPackages.sysinfo: Disable the test. Metrics are not collected …

0145fac

…properly on the sandbox of macOS.

junjihashimoto force-pushed the feature/hasktorch branch from b2fb84e to 0145fac Compare January 1, 2025 07:16

maralorn merged commit d3780c9 into NixOS:haskell-updates Jan 3, 2025
22 of 23 checks passed

junjihashimoto deleted the feature/hasktorch branch January 5, 2025 05:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

haskellPackages.libtorch-ffi: Fix the link to libtorch #367998

haskellPackages.libtorch-ffi: Fix the link to libtorch #367998

junjihashimoto commented Dec 24, 2024 •

edited

Loading

junjihashimoto commented Dec 25, 2024

SomeoneSerge Dec 25, 2024

SomeoneSerge Dec 25, 2024

SomeoneSerge Dec 25, 2024

junjihashimoto Dec 26, 2024

SomeoneSerge Dec 25, 2024

junjihashimoto Dec 26, 2024

junjihashimoto Dec 26, 2024 •

edited

Loading

SomeoneSerge Jan 1, 2025

junjihashimoto Jan 3, 2025 •

edited

Loading

SomeoneSerge Jan 3, 2025

sternenseemann commented Dec 26, 2024

junjihashimoto commented Dec 28, 2024 •

edited

Loading

sternenseemann commented Dec 28, 2024

junjihashimoto commented Dec 28, 2024

junjihashimoto commented Dec 28, 2024 •

edited

Loading

junjihashimoto commented Dec 28, 2024

maralorn Dec 31, 2024

sternenseemann Dec 31, 2024

junjihashimoto Jan 1, 2025

sternenseemann commented Jan 17, 2025

junjihashimoto commented Jan 18, 2025

junjihashimoto commented Jan 18, 2025

sternenseemann commented Jan 18, 2025

haskellPackages.libtorch-ffi: Fix the link to libtorch #367998

haskellPackages.libtorch-ffi: Fix the link to libtorch #367998

Conversation

junjihashimoto commented Dec 24, 2024 • edited Loading

Things done

junjihashimoto commented Dec 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

junjihashimoto Dec 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

junjihashimoto Jan 3, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sternenseemann commented Dec 26, 2024

junjihashimoto commented Dec 28, 2024 • edited Loading

sternenseemann commented Dec 28, 2024

junjihashimoto commented Dec 28, 2024

junjihashimoto commented Dec 28, 2024 • edited Loading

junjihashimoto commented Dec 28, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sternenseemann commented Jan 17, 2025

junjihashimoto commented Jan 18, 2025

junjihashimoto commented Jan 18, 2025

sternenseemann commented Jan 18, 2025

junjihashimoto commented Dec 24, 2024 •

edited

Loading

junjihashimoto Dec 26, 2024 •

edited

Loading

junjihashimoto Jan 3, 2025 •

edited

Loading

junjihashimoto commented Dec 28, 2024 •

edited

Loading

junjihashimoto commented Dec 28, 2024 •

edited

Loading