Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gallery-dl: move to by-name, tweak, 1.28.1 -> 1.28.2 #367218

Merged
merged 4 commits into from
Dec 29, 2024

Conversation

lucasew
Copy link
Contributor

@lucasew lucasew commented Dec 21, 2024

  • gallery-dl: move to by-name
  • gallery-dl: tweak package, add myself as maintainer
  • gallery-dl: 1.28.1 -> 1.28.2

Closes #366920

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: lucasew <[email protected]>
@lucasew
Copy link
Contributor Author

lucasew commented Dec 22, 2024

Tested locally with the example album and it worked!

This one:

gallery-dl "https://danbooru.donmai.us/posts?tags=bonocho"

@DontEatOreo
Copy link
Member

FYI: You can have all builds results be in the same message, https://github.com/Mic92/nixpkgs-review?tab=readme-ov-file#review-changes-for-other-operating-systemsarchitectures

@lucasew
Copy link
Contributor Author

lucasew commented Dec 24, 2024

FYI: You can have all builds results be in the same message, https://github.com/Mic92/nixpkgs-review?tab=readme-ov-file#review-changes-for-other-operating-systemsarchitectures

I fixed that. Each workflow generates a report artifact and in the end there is a workflow that joins them. Doing this using nixpkgs-review native system would require me to setup remote builders for a dispatcher workflow, and also networking between them by consequence. That way the architecture doesn't become too complex.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4997

@thiagokokada
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367218


x86_64-linux

✅ 2 packages built:
  • gallery-dl
  • gallery-dl.dist

@thiagokokada
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367218


aarch64-darwin

✅ 2 packages built:
  • gallery-dl
  • gallery-dl.dist

@thiagokokada
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367218


x86_64-darwin

✅ 2 packages built:
  • gallery-dl
  • gallery-dl.dist

@thiagokokada thiagokokada merged commit 9f92a84 into NixOS:master Dec 29, 2024
43 of 44 checks passed
@lucasew lucasew deleted the 20241221-gallery-dl branch December 30, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants