-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gallery-dl: move to by-name, tweak, 1.28.1 -> 1.28.2 #367218
Conversation
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
Signed-off-by: lucasew <[email protected]>
Tested locally with the example album and it worked! This one:
|
FYI: You can have all builds results be in the same message, https://github.com/Mic92/nixpkgs-review?tab=readme-ov-file#review-changes-for-other-operating-systemsarchitectures |
I fixed that. Each workflow generates a report artifact and in the end there is a workflow that joins them. Doing this using nixpkgs-review native system would require me to setup remote builders for a dispatcher workflow, and also networking between them by consequence. That way the architecture doesn't become too complex. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4997 |
|
|
|
Closes #366920
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.