-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.netbox-floorplan-plugin: init at 0.6.0 #367107
Conversation
cc maintainers of netbox for review: @minijackson / @RaitoBezarius / @n0emis |
Nice 🤩 |
pkgs/development/python-modules/netbox-floorplan-plugin/default.nix
Outdated
Show resolved
Hide resolved
@felbinger this does work on my instance and was tested with #368036 and netbox from 24.11. My client is Firefox from 24.11. If I remember correctly, you first have to upload a Floorplan image in the settings for the plug-in before you can use the UI you have shown. I will try to setup a new clean instance later for testing. |
Weird: Same setup. I tried uploading a floorplan (which was successful), but it didn't work eighter. To be fair: I tested it in a netbox instance which has been running for a long time, so this might be a problem. |
Don't forget to rebase the last three commits into one ( |
Have you been able to confirm that the plugin works in a fresh instance? Even with another browser it doesn't seam to be working on my instances. |
Sorry, I did not have time to test it at work yet. Will try to do it sometime next week. |
pkgs/development/python-modules/netbox-floorplan-plugin/default.nix
Outdated
Show resolved
Hide resolved
Tested on a fresh instance today (running 4.1.10 from #368036). The plugin is working fine. It would be helpful if you could please check at the logs of your netbox instance/ your browser to check if an error has occurred somewhere. If an error has occurred, please share the logs and let's figure out if this is packaging related or an upstream issue. |
Figured it out. Had to run |
@felbinger if I did the rebase correctly than the last three commits should now be squashed with a proper commit message. You were retained as a co-author. |
Any reasons for not squashing the last three (init, fixup 1, fixup 2) into just the init commit? No need for the co-author, if you don't want to have it on your "init 0.5.0" commit. |
There was no particular reason. I've squashed the other two too now. Regardless, I noticed that 0.6.0 was released upstream (for netbox 4.2.0 support). Should I update this PR for the new release of the plugin or open a second PR after this is merged? |
I would update this pr. |
PR was updated. I don't have a 4.2 instance to properly test the support of the plugin, will try later on a 4.1.10 instance. |
pkgs/development/python-modules/netbox-floorplan-plugin/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/netbox-floorplan-plugin/default.nix
Outdated
Show resolved
Hide resolved
I will rebase this asap, apparently a merge conflicts also needs to be resoled. Note: also tested this on a 4.1.10 instance, still worked fine for me. |
Co-authored-by: Nico Felbinger <[email protected]> Co-authored-by: Sandro <[email protected]>
Hi, when are you planning on rebasing it? With the "Merge branch master into master" this will not be mergeable... If you want to I can assist you finishing it |
We opened #374618 to remove the merge commit. I couldn't push to your fork because you opened the PR from master. |
Thank you for taking over the last rebase and making a new PR. I'll try to open new PRs based on the feedback for this one. |
👍 Feel free to contact me for collaboration, I packaged a bunch of plugins yesterday (dns, napalm, topology views, ...) |
Add the
netbox-floorplan-plugin
. This plugin can be enabled innetbox
asnetbox_floorplan
. The used source variant is the official Netbox Community version. I've also added myself as a maintainer for this plugin.Related to #261522, I will likely add PRs for more official plugins in the next few weeks.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.