Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supergee: init at 0-unstable-2023-11-21 #367050

Merged
merged 1 commit into from
Dec 29, 2024
Merged

supergee: init at 0-unstable-2023-11-21 #367050

merged 1 commit into from
Dec 29, 2024

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Dec 21, 2024 •
edited
Loading

Fix #367047

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Bot-wxt1221 Bot-wxt1221 marked this pull request as draft December 21, 2024 09:34
@Bot-wxt1221 Bot-wxt1221 marked this pull request as ready for review December 21, 2024 14:02
@Bot-wxt1221 Bot-wxt1221 force-pushed the supergee branch 2 times, most recently from 1073c03 to aa6a80e Compare December 21, 2024 14:25
lucasew
lucasew suggested changes Dec 21, 2024
View reviewed changes
pkgs/by-name/su/supergee/package.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 22, 2024
@Bot-wxt1221
Copy link
Member Author

@ofborg build supergee

@Bot-wxt1221
Copy link
Member Author

@ofborg build supergee

@Bot-wxt1221 Bot-wxt1221 requested a review from lucasew December 22, 2024 05:28
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4990

@Bot-wxt1221
Copy link
Member Author

@SuperSandro2000 Done.

@github-actions github-actions bot added the 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin label Dec 23, 2024
@Bot-wxt1221
Copy link
Member Author

nixpkgs-reviewd workflow finished

Status and logs: https://github.com/Bot-wxt1221/nixpkgs-reviewd/actions/runs/12492396426

GaetanLepage
GaetanLepage requested changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, have you tried adding versionCheckHook ?

pkgs/by-name/su/supergee/package.nix Show resolved Hide resolved
pkgs/by-name/su/supergee/package.nix Outdated Show resolved Hide resolved
@Bot-wxt1221 Bot-wxt1221 force-pushed the supergee branch 3 times, most recently from 3c4c994 to 1802c3d Compare December 29, 2024 08:38
@Bot-wxt1221
Copy link
Member Author

@GaetanLepage No version now so I don't think versionCheckHook is needed.

@GaetanLepage
Copy link
Contributor

Unfortunately, we'll have to wait for #363130 and #368790 to be merged first.

@Bot-wxt1221 Bot-wxt1221 added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Dec 29, 2024
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367050

x86_64-linux

❌ 1 package failed to build:
  • supergee

aarch64-linux

❌ 1 package failed to build:
  • supergee

@GaetanLepage
Copy link
Contributor

librosa doesn't seem compatible with numpy2...

@GaetanLepage
Copy link
Contributor

librosa doesn't seem compatible with numpy2...

Fixed in #369116

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367050

x86_64-linux

✅ 1 package built:
  • supergee

aarch64-linux

✅ 1 package built:
  • supergee

GaetanLepage
GaetanLepage approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested locally/

@GaetanLepage GaetanLepage merged commit 0666419 into NixOS:master Dec 29, 2024
40 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@lucasew lucasew Awaiting requested review from lucasew

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
2.status: wait-for-upstream Waiting for upstream fix (or their other action). 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: SuperGee
5 participants
@Bot-wxt1221 @nixos-discourse @GaetanLepage @SuperSandro2000 @lucasew