Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ani-cli v4.6 -> v4.8 (For NixOS 23.11) #366169

Closed
wants to merge 1 commit into from

Conversation

Rishik-Y
Copy link
Contributor

Adding support for 23.11

Tests: Ran it multiple times and is already present in NisOS 24.05

Package Information

  • Package name: ani-cli
  • Latest released version: 4.8 (for 23.11)
  • Current version on the unstable channel: 4.9
  • Current version on the stable/release channel: 4.6

Changes: Minor changes so Latest version works in 23.11 stable

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Maintainer ping:

@skykanin

@Rishik-Y Rishik-Y changed the title Update ani-cli v4.6 -> v4.8 Update ani-cli v4.6 -> v4.8 (For NixOS 23.11) Dec 18, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 18, 2024
@ofborg ofborg bot requested a review from skykanin December 19, 2024 01:12
@Rishik-Y Rishik-Y marked this pull request as draft December 19, 2024 09:57
@Rishik-Y Rishik-Y marked this pull request as ready for review December 19, 2024 09:58
@wegank
Copy link
Member

wegank commented Dec 19, 2024

NixOS <=23.11 is EOL.

@wegank wegank closed this Dec 19, 2024
@Rishik-Y Rishik-Y deleted the patch-4 branch December 19, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants