ani-cli: 4.8 -> 4.9 #366140
ani-cli: 4.8 -> 4.9 #366140
Conversation
wegank
added
the
12.approvals: 1
Rishik-Y
changed the title
| { | ||
| fetchFromGitHub, | ||
| makeWrapper, | ||
| stdenvNoCC, | ||
| lib, | ||
| gnugrep, | ||
| gnused, | ||
| curl, | ||
| catt, | ||
| syncplay, | ||
| ffmpeg, | ||
| fzf, | ||
| aria2, | ||
| withMpv ? true, | ||
| mpv, | ||
| withVlc ? false, | ||
| vlc, | ||
| withIina ? false, | ||
| iina, | ||
| chromecastSupport ? false, | ||
| syncSupport ? false, | ||
| { fetchFromGitHub | ||
| , makeWrapper | ||
| , stdenvNoCC | ||
| , lib | ||
| , gnugrep | ||
| , gnused | ||
| , curl | ||
| , catt | ||
| , syncplay | ||
| , ffmpeg | ||
| , fzf | ||
| , aria2 | ||
| , withMpv ? true, mpv | ||
| , withVlc ? false, vlc | ||
| , withIina ? false, iina | ||
| , chromecastSupport ? false | ||
| , syncSupport ? false |
There was a problem hiding this comment.
Please remove the unnecessary formatting changes
| let | ||
| player = [ ] ++ lib.optional withMpv mpv ++ lib.optional withVlc vlc ++ lib.optional withIina iina; | ||
| in | ||
| [ | ||
| gnugrep | ||
| gnused | ||
| curl | ||
| fzf | ||
| ffmpeg | ||
| aria2 | ||
| ] | ||
| ++ player | ||
| ++ lib.optional chromecastSupport catt | ||
| ++ lib.optional syncSupport syncplay; | ||
| let player = [] | ||
| ++ lib.optional withMpv mpv | ||
| ++ lib.optional withVlc vlc | ||
| ++ lib.optional withIina iina; | ||
| in [ gnugrep gnused curl fzf ffmpeg aria2 ] | ||
| ++ player | ||
| ++ lib.optional chromecastSupport catt | ||
| ++ lib.optional syncSupport syncplay; |
There was a problem hiding this comment.
If a formatter is used, make sure that you're using nixfmt-rfc-style
There was a problem hiding this comment.
Okay will do that in future! 👍️
Co-authored-by: Donovan Glover <[email protected]>
|
I Have made the necessary changes! |
wegank
removed
the
12.approvals: 1
Co-authored-by: Donovan Glover <[email protected]>
Oh... |
|
You can see the deprecated label on https://search.nixos.org/ and https://status.nixos.org/ For contributing to nixpkgs, it's ideal to target the |
Adding support for 24.05
Tests: Ran it multiple times and is already present in NisOS 24.11
Package Information
Changes: Minor changes so Latest version works in 24.05 stable
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Maintainer ping:
@skykanin