Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n8n: package improvements #364947

Merged
merged 4 commits into from
Dec 29, 2024
Merged

n8n: package improvements #364947

merged 4 commits into from
Dec 29, 2024

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Dec 13, 2024

Now r-ryantm should only post stable (non-prerelease) n8n updates.

Thanks for the suggestion @liberodark in #364897 (comment)!

Superseeds #364897

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gepbird
Copy link
Contributor Author

gepbird commented Dec 13, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 364947


x86_64-linux

✅ 1 package built:
  • n8n

@gepbird
Copy link
Contributor Author

gepbird commented Dec 21, 2024

Reduced the size of the built package from 2018M to 890M, and the fixup phase now takes half as long, which can save 10 minutes of build time on a slower machine with an HDD.

@gepbird gepbird changed the title n8n: 1.70.1 -> 1.71.3, update to stable release n8n: 1.70.1 -> 1.71.3, package improvements Dec 21, 2024
@gepbird
Copy link
Contributor Author

gepbird commented Dec 22, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 364947


x86_64-linux

✅ 1 package built:
  • n8n

@wolfgangwalther
Copy link
Contributor

Needs a rebase after #364897 is merged.

@gepbird gepbird changed the title n8n: 1.70.1 -> 1.71.3, package improvements n8n: package improvements Dec 24, 2024
@gepbird
Copy link
Contributor Author

gepbird commented Dec 28, 2024

Further reduced the built package size to 671M

@wolfgangwalther wolfgangwalther merged commit e8fed40 into NixOS:master Dec 29, 2024
42 of 43 checks passed
@gepbird gepbird deleted the n8n-1.71.3 branch December 30, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants