Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.ollama: 0.3.3 -> 0.4.4 #364280

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

Erethon
Copy link
Contributor

@Erethon Erethon commented Dec 11, 2024

Upgrade package to the latest upstream version (git changelog). Pydantic is needed to build the package now it seems.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Erethon
Copy link
Contributor Author

Erethon commented Dec 11, 2024

Running nixpkgs-review for this unfortunately crashes my system, I'll see if I can run it on a beefier host.

@ofborg ofborg bot requested a review from fabaff December 16, 2024 23:35
@FliegendeWurst FliegendeWurst merged commit 38c5f83 into NixOS:master Dec 29, 2024
39 of 40 checks passed
@fabaff
Copy link
Member

fabaff commented Dec 30, 2024

@FliegendeWurst, why was this merged? The comment was not addressed.

@FliegendeWurst
Copy link
Member

I built this package and most dependents locally.

@fabaff
Copy link
Member

fabaff commented Dec 30, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 364280


x86_64-linux

⏩ 14 packages marked as broken and skipped:
  • private-gpt
  • private-gpt.dist
  • python311Packages.llama-index-embeddings-ollama
  • python311Packages.llama-index-embeddings-ollama.dist
  • python311Packages.llama-index-llms-ollama
  • python311Packages.llama-index-llms-ollama.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.llama-index-embeddings-ollama
  • python312Packages.llama-index-embeddings-ollama.dist
  • python312Packages.llama-index-llms-ollama
  • python312Packages.llama-index-llms-ollama.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
❌ 3 packages failed to build:
  • home-assistant-component-tests.ollama
  • oterm
  • oterm.dist
✅ 8 packages built:
  • python311Packages.langchain-ollama
  • python311Packages.langchain-ollama.dist
  • python311Packages.ollama
  • python311Packages.ollama.dist
  • python312Packages.langchain-ollama
  • python312Packages.langchain-ollama.dist
  • python312Packages.ollama
  • python312Packages.ollama.dist

@FliegendeWurst
Copy link
Member

oterm builds for me. home-assistant-component-tests.ollama pins an old version of pydantic.

@FliegendeWurst
Copy link
Member

I will open another PR for home-assistant.

@FliegendeWurst
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants