ocamlformat: Build on OCaml 4.14 #361404
Merged
ocamlformat: Build on OCaml 4.14 #361404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OCamlformat fails to build since the bump to OCaml 5.2 in NixOS#346071 error: ocamlformat 0.26.1 is not available for OCaml 5.2.1 This changes which version of the compiler is used to build OCamlformat. 4.14 is used to increase sharing when several versions of the tool are used at the same time. This will not change OCamlformat's behaviors.
|
ocamlformat 0.26.2 builds fine with OCaml 5.2.1 and should be built with the default version of the OCaml compiler. |
|
Right! And it will also build fine with 5.3. Fixed |
|
Successfully created backport PR for |
nixpkgs-ci bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
* ocamlformat: Build on OCaml 4.14 OCamlformat fails to build since the bump to OCaml 5.2 in #346071 error: ocamlformat 0.26.1 is not available for OCaml 5.2.1 This changes which version of the compiler is used to build OCamlformat. 4.14 is used to increase sharing when several versions of the tool are used at the same time. This will not change OCamlformat's behaviors. * ocamlformat_0_26_2: Build on the latest compiler (cherry picked from commit 8d3033a)
1 task
vbgl
pushed a commit
that referenced
this pull request
Dec 4, 2024
* ocamlformat: Build on OCaml 4.14 OCamlformat fails to build since the bump to OCaml 5.2 in #346071 error: ocamlformat 0.26.1 is not available for OCaml 5.2.1 This changes which version of the compiler is used to build OCamlformat. 4.14 is used to increase sharing when several versions of the tool are used at the same time. This will not change OCamlformat's behaviors. * ocamlformat_0_26_2: Build on the latest compiler (cherry picked from commit 8d3033a)
RedEtherbloom
pushed a commit
to RedEtherbloom/nixpkgs
that referenced
this pull request
Dec 4, 2024
* ocamlformat: Build on OCaml 4.14 OCamlformat fails to build since the bump to OCaml 5.2 in NixOS#346071 error: ocamlformat 0.26.1 is not available for OCaml 5.2.1 This changes which version of the compiler is used to build OCamlformat. 4.14 is used to increase sharing when several versions of the tool are used at the same time. This will not change OCamlformat's behaviors. * ocamlformat_0_26_2: Build on the latest compiler
mkg20001
pushed a commit
to mkg20001/nixpkgs
that referenced
this pull request
Dec 5, 2024
* ocamlformat: Build on OCaml 4.14 OCamlformat fails to build since the bump to OCaml 5.2 in NixOS#346071 error: ocamlformat 0.26.1 is not available for OCaml 5.2.1 This changes which version of the compiler is used to build OCamlformat. 4.14 is used to increase sharing when several versions of the tool are used at the same time. This will not change OCamlformat's behaviors. * ocamlformat_0_26_2: Build on the latest compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCamlformat fails to build since the bump to OCaml 5.2 in #346071
This changes which version of the compiler is used to build OCamlformat. 4.14 is used to increase sharing when several versions of the tool are used at the same time. This will not change OCamlformat's behaviors.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.