Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discrete-scroll: 0.1.1 -> 1.2.1 #359465

Merged
merged 3 commits into from
Nov 28, 2024
Merged

discrete-scroll: 0.1.1 -> 1.2.1 #359465

merged 3 commits into from
Nov 28, 2024

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 26, 2024 •
edited
Loading

https://github.com/emreyolcu/discrete-scroll/releases/tag/v1.2.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Nov 27, 2024
@ofborg ofborg bot requested a review from bb2020 November 27, 2024 22:23
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 27, 2024
@wegank
Copy link
Member Author

wegank commented Nov 27, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359465

x86_64-darwin

✅ 1 package built:
  • discrete-scroll

aarch64-darwin

✅ 1 package built:
  • discrete-scroll

@bb2020
Copy link
Member

bb2020 commented Nov 27, 2024

bb2020@0ff829b

@wegank wegank force-pushed the discrete-scroll-bump branch from a149e46 to e58e116 Compare November 27, 2024 23:45
@wegank
Copy link
Member Author

wegank commented Nov 27, 2024

I think repo = finalAttrs.pname; is discouraged in #277994, and I'm using nixfmt as it is the official formatter (and formatting with nixfmt will be mandatory soon, see https://discourse.nixos.org/t/nix-formatting-team-treewide-nixpkgs-formatting/56666).

Otherwise, I've applied all other changes from the commit.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 28, 2024
@wegank
Copy link
Member Author

wegank commented Nov 28, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359465

x86_64-darwin

✅ 1 package built:
  • discrete-scroll

aarch64-darwin

✅ 1 package built:
  • discrete-scroll

@wegank wegank merged commit 0ecd14b into NixOS:master Nov 28, 2024
17 of 18 checks passed
@wegank wegank deleted the discrete-scroll-bump branch November 28, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb2020 bb2020 bb2020 approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wegank @bb2020