Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convfont: 1.0 -> 1.2 #359462

Merged
merged 1 commit into from
Dec 18, 2024
Merged

convfont: 1.0 -> 1.2 #359462

merged 1 commit into from
Dec 18, 2024

Conversation

myclevorname
Copy link
Contributor

@myclevorname myclevorname commented Nov 26, 2024

convfont is a program that converts fonts to the format compatible with the fontlibc library in the TI-84 Plus CE C toolchain. The WTFPL license listed in meta.license was wrong, as there is no license in the repo as of then and right now.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Ben9986
Copy link
Contributor

Ben9986 commented Nov 27, 2024

If there is no upstream license it should be set to unfree. link

meta.license must be set and match the upstream license.
If there is no upstream license, meta.license should default to lib.licenses.unfree

@symphorien symphorien merged commit fb9ff56 into NixOS:master Dec 18, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants