Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: fix build with boost 1.86 #359441

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Nov 26, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@flokli
Copy link
Contributor

flokli commented Dec 28, 2024

The boost bump ended in master, so this should target master too.

I manually cherry-picked this and will update this PR, retargeting master.

@flokli flokli marked this pull request as draft December 28, 2024 12:34
@flokli flokli force-pushed the pkgs/ledger-fix-boost-1.86 branch from 4561543 to a4cfa02 Compare December 28, 2024 12:36
@flokli flokli changed the base branch from staging to master December 28, 2024 12:36
@flokli flokli marked this pull request as ready for review December 28, 2024 12:37
@flokli flokli changed the title [staging] ledger: fix build with boost 1.86 ledger: fix build with boost 1.86 Dec 28, 2024
@flokli flokli merged commit 1a18ce1 into NixOS:master Dec 28, 2024
39 of 40 checks passed
@tobim tobim deleted the pkgs/ledger-fix-boost-1.86 branch December 28, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants