python312Packages.pygerber: init at 2.4.2, pytest-lsp: init at 0.4.3

[clemjvdm]

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[clemjvdm]

do I need to do anything else? Sorry it's my first PR so I'm not sure. @steeleduncan

[steeleduncan]

I am not familiar enough with python derivations to leave an approving review, but I certainly wouldn't want to block it

If you can find someone who has merged some python commits recently and ping them for a review that is probably the best approach to get it merged

[clemjvdm]

I am not familiar enough with python derivations to leave an approving review, but I certainly wouldn't want to block it

If you can find someone who has merged some python commits recently and ping them for a review that is probably the best approach to get it merged

@natsukium Hello, hope it's ok for me to ping you here. I opened this PR about 3 weeks ago and I wasn't sure if I had to do anything else to get it merged.

[clemjvdm]

@FliegendeWurst Just committed your suggestions, fixed a little error and squashed them, hopefully this is how I was supposed to do this. Anything else I should do?

[FliegendeWurst]

Yes. So far you only activated the import check. It would be good to run the real test suite, if the project has one. Add pytestCheckHook (or another hook, depending on the framework) to nativeCheckInputs for that.

[clemjvdm]

@FliegendeWurst I looked into it, but I can't test because pytest-lsp doesn't yet exist on nixpkgs :(

[FliegendeWurst]

Here you go. Untested.

{
  lib,
  fetchPypi,
  buildPythonPackage,
  hatchling,
  pygls,
  pytestCheckHook,
  pytest-asyncio,
}:

buildPythonPackage rec {
  pname = "pytest-lsp";
  version = "0.4.3";
  pyproject = true;

  src = fetchPypi {
    inherit version;
    pname = "pytest_lsp";
    hash = "sha256-ND9r2i+qMg7V/Ld8lCDScDzlZdHRRP6CfjGYp9wpkRw=";
  };

  build-system = [
    hatchling
  ];

  dependencies = [
    pygls
    pytest-asyncio
  ];

  nativeCheckInputs = [
    pytestCheckHook
  ];

  pythonImportsCheck = [ "pytest_lsp" ];

  meta = {
    homepage = "https://github.com/swyddfa/lsp-devtools";
    changelog = "https://github.com/swyddfa/lsp-devtools/blob/develop/lib/pytest-lsp/CHANGES.md";
    description = "Pytest plugin for writing end-to-end tests for language servers";
    license = lib.licenses.mit;
    maintainers = with lib.maintainers; [ clemjvdm fliegendewurst ];
  };
}

[clemjvdm]

@FliegendeWurst Thanks a lot! But I'm sorry, I'm not sure how I should go about this. Open a new PR with pytest_lsp, or just write this somewhere in this PR?

[FliegendeWurst]

You can put it in this PR. Ideally it would be done in a commit before the pygerber package is added.

[clemjvdm]

@FliegendeWurst Just to be sure before I do this, pygerber documentation states that to run tests one should do:

poetry shell
poe run-unit-tests

I assumed this wasn't the right way to do this here since this would imply letting poetry manage dependencies. I also tried just installing the required dependencies and doing poe run-unit-tests but this requires poetry and nix will only let me use poetry-core:

error: poetry was promoted to a top-level attribute, use poetry-core to build Python packages

Which is why I figured maybe using pytests (which poepoet refers to) directly was the right approach. But in hindsight I'm not sure.

[clemjvdm]

I think either way we'll need pytest-lsp.

[FliegendeWurst]

I think pytestCheckHook will work. You may need to add some more plugins though:

https://github.com/Argmaster/pygerber/blob/c4208a98293d2abf1101804f6166df79742b0de5/pyproject.toml#L84-L89

[clemjvdm]

@FliegendeWurst Yeah I figured, I'll try that then. Thanks :)

[clemjvdm]

@FliegendeWurst New issue! Yay! I was able to get everything working with pytest-lsp (thanks again). But it seems pygerber's tests pull assets from github (which isn't allowed by the nix build phase).

Is there a good way of solving this? I presume maybe we can fetch them in nix and then patch the tests but I don't have time nor am I qualified to do that I think.

[FliegendeWurst]

If it's only some tests you can disable them using disabledTests = [ .... ].

[clemjvdm]

@FliegendeWurst Ok that worked! Do we care about skipped, xfailed and xpassed tests?

============= 427 passed, 2 skipped, 8 xfailed, 1 xpassed in 7.08s =============

Otherwise I'll commit.

[FliegendeWurst]

That looks good to me 👍

[clemjvdm]

@FliegendeWurst All done. Thanks you sm for the help :)