Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gerrit: 3.10.2 -> 3.10.3 #359389

Merged
merged 2 commits into from
Nov 30, 2024
Merged

gerrit: 3.10.2 -> 3.10.3 #359389

merged 2 commits into from
Nov 30, 2024

Conversation

felixsinger
Copy link
Member

@felixsinger felixsinger commented Nov 26, 2024 •
edited
Loading

Release notes: https://www.gerritcodereview.com/3.10.html#3103

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@felixsinger
gerrit: 3.10.2 -> 3.10.3
a463394 
Signed-off-by: Felix Singer <[email protected]>
@felixsinger
gerrit: Apply nixfmt
47f6cf6 
Signed-off-by: Felix Singer <[email protected]>
@felixsinger felixsinger added backport release-24.11 Backport PR automatically 1.severity: security Issues which raise a security issue, or PRs that fix one and removed 1.severity: security Issues which raise a security issue, or PRs that fix one labels Nov 26, 2024
@felixsinger
Copy link
Member Author

@GrahamcOfBorg test gerrit

@ofborg ofborg bot requested review from flokli and zimbatm November 27, 2024 16:20
@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 28, 2024
@felixsinger felixsinger requested a review from Atemu November 30, 2024 04:28
Atemu
Atemu approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream patch notes contain quite a few more changes than I'd be comfortable backporting but otherwise this LGTM.

@Atemu Atemu removed the backport release-24.11 Backport PR automatically label Nov 30, 2024
@Atemu Atemu merged commit 30e8e79 into NixOS:master Nov 30, 2024
49 of 51 checks passed
@felixsinger
Copy link
Member Author

felixsinger commented Nov 30, 2024 •
edited
Loading

The upstream patch notes contain quite a few more changes than I'd be comfortable backporting but otherwise this LGTM.

What exactly? It's a point release. I can't see anything that has a lot of impact. Also, I'm very sure that there will be another point release in the future fixing security issues, which also will include the changes from 3.10.3. We can't just skip that.

Edit: Created the backport. If anyone is comfortable enough, please submit it.

@felixsinger felixsinger added the backport release-24.11 Backport PR automatically label Nov 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 30, 2024
Merged
1 task
@felixsinger felixsinger deleted the pkgs/gerrit/update branch November 30, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atemu Atemu Atemu approved these changes

@zimbatm zimbatm zimbatm approved these changes

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixsinger @zimbatm @Atemu @wegank