llvmPackages.bintuils: Hack ranlib to ignore -t
#359387
Merged
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old versions of libtool for OpenBSD insist on adding the `-t` flag to ranlib, which updates the timestamp. llvm-ranlib does not support `-t` and as no plans to do so [1], since it makes builds less reproducable. OpenBSD upstream deals with this by patching ranlib to ignore the `-t` flag [2]. Instead of writing patches for all LLVM versions or re-running `autoreconf` on all packages that use libtool, we can wrap ranlib to ignore the flag. [1]: llvm/llvm-project#57129 [2]: openbsd/src@d00990c
13 tasks
Ericson2314
approved these changes
Nov 26, 2024
ofborg
bot
added
10.rebuild-darwin: 0
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old versions of libtool for OpenBSD insist on adding the
-tflag to ranlib, which updates the timestamp. llvm-ranlib does not support-tand as no plans to do so 1, since it makes builds less reproducable. OpenBSD upstream deals with this by patching ranlib to ignore the-tflag 2.Instead of writing patches for all LLVM versions or re-running
autoreconfon all packages that use libtool, we can wrap ranlib to ignore the flag.An example package that requires this change is
libxcrypt, which you can build withpkgsCross.x86_64-openbsd.libxcryptThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.