Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdbook: 0.4.42 -> 0.4.43 #359312

Merged
merged 1 commit into from
Dec 3, 2024
Merged

mdbook: 0.4.42 -> 0.4.43 #359312

merged 1 commit into from
Dec 3, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Nov 26, 2024

Changes: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0443

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 27, 2024
@uncenter

This comment was marked as resolved.

@trofi
Copy link
Contributor Author

trofi commented Dec 1, 2024

❌ 188 packages failed to build:

Looks like even mdbook itself failed to build for you. Do you still have a build log by chance to check if it's a genuine mdbook build problem or some dependency failure?

@uncenter
Copy link
Member

uncenter commented Dec 1, 2024

Oh hmm yeah I'm not sure why that went through just now 😓 - cancelled a build earlier, running it right now at the minute. Didn't see that it had posted this! Ignore that...

@fpletz fpletz merged commit c32b0ea into NixOS:staging Dec 3, 2024
48 of 49 checks passed
@trofi trofi deleted the mdbook-update branch December 3, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants