Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fwupd: 2.0.1 -> 2.0.2 #359279

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fwupd: 2.0.1 -> 2.0.2 #359279

merged 1 commit into from
Nov 26, 2024

Conversation

r-vdp
Copy link
Contributor

@r-vdp r-vdp commented Nov 26, 2024

Things done

See: https://github.com/fwupd/fwupd/releases/tag/2.0.2

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@r-vdp r-vdp requested a review from GaetanLepage November 26, 2024 13:02
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359279


x86_64-linux

❌ 1 package failed to build:
  • libsForQt5.discover
✅ 26 packages built:
  • fwupd
  • fwupd.debug
  • fwupd.dev
  • fwupd.devdoc
  • fwupd.installedTests
  • fwupd.lib
  • fwupd.man
  • gnome-firmware
  • gnome-software
  • kdePackages.discover
  • kdePackages.discover.debug
  • kdePackages.discover.dev
  • kdePackages.discover.devtools
  • libsForQt5.kinfocenter
  • pantheon.elementary-greeter
  • pantheon.elementary-onboarding
  • pantheon.elementary-settings-daemon
  • pantheon.switchboard-plug-about
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-power
  • pantheon.switchboard-plug-security-privacy
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-quick-settings
  • pantheon.wingpanel-with-indicators

aarch64-linux

❌ 1 package failed to build:
  • libsForQt5.discover
✅ 25 packages built:
  • fwupd
  • fwupd.debug
  • fwupd.dev
  • fwupd.devdoc
  • fwupd.installedTests
  • fwupd.lib
  • fwupd.man
  • gnome-firmware
  • kdePackages.discover
  • kdePackages.discover.debug
  • kdePackages.discover.dev
  • kdePackages.discover.devtools
  • libsForQt5.kinfocenter
  • pantheon.elementary-greeter
  • pantheon.elementary-onboarding
  • pantheon.elementary-settings-daemon
  • pantheon.switchboard-plug-about
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-power
  • pantheon.switchboard-plug-security-privacy
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-quick-settings
  • pantheon.wingpanel-with-indicators

x86_64-darwin


aarch64-darwin

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 26, 2024
@GaetanLepage GaetanLepage merged commit 5bd1131 into NixOS:master Nov 26, 2024
17 of 18 checks passed
@r-vdp r-vdp deleted the fwupd branch November 27, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants