Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goreleaser: 2.4.5 -> 2.4.8 #358985

Merged
merged 1 commit into from
Nov 26, 2024
Merged

goreleaser: 2.4.5 -> 2.4.8 #358985

merged 1 commit into from
Nov 26, 2024

Conversation

SuperSandro2000
Copy link
Member

Diff: goreleaser/goreleaser@v2.4.5...v2.4.8

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@techknowlogick
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 358985

aarch64-darwin

✅ 1 package built:
  • goreleaser

@techknowlogick techknowlogick added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 26, 2024
@sarcasticadmin
Copy link
Member

Result of nixpkgs-review pr 358985 run on x86_64-linux 1

1 package built:
  • goreleaser

@techknowlogick techknowlogick added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Nov 26, 2024
@SuperSandro2000 SuperSandro2000 merged commit 0489850 into NixOS:master Nov 26, 2024
40 of 41 checks passed
@SuperSandro2000 SuperSandro2000 deleted the goreleaser branch November 26, 2024 17:26
@SuperSandro2000 SuperSandro2000 added the backport release-24.11 Backport PR automatically label Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-358985-to-release-24.11 origin/release-24.11
cd .worktree/backport-358985-to-release-24.11
git switch --create backport-358985-to-release-24.11
git cherry-pick -x d12dfaf2d755afdd3612aab8d7354ad528f18322

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-358985-to-release-24.11 origin/release-24.11
cd .worktree/backport-358985-to-release-24.11
git switch --create backport-358985-to-release-24.11
git cherry-pick -x d12dfaf2d755afdd3612aab8d7354ad528f18322

@SuperSandro2000 SuperSandro2000 added backport release-24.11 Backport PR automatically and removed backport release-24.11 Backport PR automatically labels Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarcasticadmin sarcasticadmin sarcasticadmin approved these changes

@caarlos0 caarlos0 caarlos0 approved these changes

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SuperSandro2000 @techknowlogick @sarcasticadmin @caarlos0