[backport 24.11] treewide: remove deprecations up until 24.11 #358798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following through on message itself. (cherry picked from commit 73df63f)
Follow through on NixOS#296384. (cherry picked from commit de69ff5)
This was planned for 21.11, so let's follow through. (cherry picked from commit 749a6fe)
Those were scheduled to be removed in 24.11, so let's do that. Added in NixOS#311893. (cherry picked from commit 9966353)
Scheduled for 24.11. (cherry picked from commit 8bdfc5e)
This is also true in 24.11 and up, so no need to state the version number explicitly. (cherry picked from commit e1e2193)
Scheduled for 24.11. Added in NixOS#272147. (cherry picked from commit 4255d7a)
This had been scheduled for removal in 23.11. (cherry picked from commit 6646eeb)
Those were scheduled for removal in 24.11. (cherry picked from commit 89981f1)
Scheduled for removal for 24.11. (cherry picked from commit 352f462)
This was scheduled for 24.11. (cherry picked from commit 97c3fa4)
This was scheduled for 24.11. (cherry picked from commit b6c3e15)
Scheduled for 24.05. (cherry picked from commit 6c258ee)
github-actions
bot
added
6.topic: nixos
nix-owners
bot
requested review from
h7x4,
infinisil,
K900,
mweinelt,
NickCao,
philiptaron,
roberth,
SuperSandro2000 and
ttuegel
|
I think we ought to backport the rest of 51da8b6 since it’s in the 24.11 release notes and all. Seems harmless to leave the paragraph in the manual for now though. |
Had been deprecated and scheduled for removal in 24.11.
Ah, true. Release notes win. Pushed. |
github-actions
bot
added
the
8.has: documentation
emilazy
approved these changes
Nov 24, 2024
|
@emilazy ofborg done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #356732
I left out the conflicting commit 51da8b6. The conflict was because the redirects.json file doesn't exist in 24.11, yet. Thus I decided not to backport the removal of
writeReferencesToFile, because that would leave us in the odd situation, that the hash for#writeReferencesToFilewould lead nowhere for the 24.11 manual, but then be redirected properly for the 25.05 version again.@emilazy
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.